Commit 33403bc7 authored by Ilpo Järvinen's avatar Ilpo Järvinen Committed by Shuah Khan

selftests/resctrl: Remove unnecessary __u64 -> unsigned long conversion

Perf counters are __u64 but the code converts them to unsigned long
before printing them out.

Remove unnecessary type conversion and retain the perf originating
value as __u64.
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: default avatarReinette Chatre <reinette.chatre@intel.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 5caf1b64
...@@ -83,9 +83,8 @@ static int reset_enable_llc_perf(pid_t pid, int cpu_no) ...@@ -83,9 +83,8 @@ static int reset_enable_llc_perf(pid_t pid, int cpu_no)
* *
* Return: =0 on success. <0 on failure. * Return: =0 on success. <0 on failure.
*/ */
static int get_llc_perf(unsigned long *llc_perf_miss) static int get_llc_perf(__u64 *llc_perf_miss)
{ {
__u64 total_misses;
int ret; int ret;
/* Stop counters after one span to get miss rate */ /* Stop counters after one span to get miss rate */
...@@ -98,8 +97,7 @@ static int get_llc_perf(unsigned long *llc_perf_miss) ...@@ -98,8 +97,7 @@ static int get_llc_perf(unsigned long *llc_perf_miss)
return -1; return -1;
} }
total_misses = rf_cqm.values[0].value; *llc_perf_miss = rf_cqm.values[0].value;
*llc_perf_miss = total_misses;
return 0; return 0;
} }
...@@ -147,14 +145,12 @@ static int get_llc_occu_resctrl(unsigned long *llc_occupancy) ...@@ -147,14 +145,12 @@ static int get_llc_occu_resctrl(unsigned long *llc_occupancy)
* *
* Return: 0 on success, < 0 on error. * Return: 0 on success, < 0 on error.
*/ */
static int print_results_cache(const char *filename, int bm_pid, static int print_results_cache(const char *filename, int bm_pid, __u64 llc_value)
unsigned long llc_value)
{ {
FILE *fp; FILE *fp;
if (strcmp(filename, "stdio") == 0 || strcmp(filename, "stderr") == 0) { if (strcmp(filename, "stdio") == 0 || strcmp(filename, "stderr") == 0) {
printf("Pid: %d \t LLC_value: %lu\n", bm_pid, printf("Pid: %d \t LLC_value: %llu\n", bm_pid, llc_value);
llc_value);
} else { } else {
fp = fopen(filename, "a"); fp = fopen(filename, "a");
if (!fp) { if (!fp) {
...@@ -162,7 +158,7 @@ static int print_results_cache(const char *filename, int bm_pid, ...@@ -162,7 +158,7 @@ static int print_results_cache(const char *filename, int bm_pid,
return -1; return -1;
} }
fprintf(fp, "Pid: %d \t llc_value: %lu\n", bm_pid, llc_value); fprintf(fp, "Pid: %d \t llc_value: %llu\n", bm_pid, llc_value);
fclose(fp); fclose(fp);
} }
...@@ -182,7 +178,7 @@ static int print_results_cache(const char *filename, int bm_pid, ...@@ -182,7 +178,7 @@ static int print_results_cache(const char *filename, int bm_pid,
*/ */
static int perf_event_measure(const char *filename, int bm_pid) static int perf_event_measure(const char *filename, int bm_pid)
{ {
unsigned long llc_perf_miss = 0; __u64 llc_perf_miss = 0;
int ret; int ret;
ret = get_llc_perf(&llc_perf_miss); ret = get_llc_perf(&llc_perf_miss);
...@@ -285,11 +281,10 @@ int cat_val(struct resctrl_val_param *param, size_t span) ...@@ -285,11 +281,10 @@ int cat_val(struct resctrl_val_param *param, size_t span)
* @cache_span: Cache span * @cache_span: Cache span
* @lines: @cache_span in lines or bytes * @lines: @cache_span in lines or bytes
*/ */
void show_cache_info(int no_of_bits, unsigned long avg_llc_val, void show_cache_info(int no_of_bits, __u64 avg_llc_val, size_t cache_span, bool lines)
size_t cache_span, bool lines)
{ {
ksft_print_msg("Number of bits: %d\n", no_of_bits); ksft_print_msg("Number of bits: %d\n", no_of_bits);
ksft_print_msg("Average LLC val: %lu\n", avg_llc_val); ksft_print_msg("Average LLC val: %llu\n", avg_llc_val);
ksft_print_msg("Cache span (%s): %zu\n", lines ? "lines" : "bytes", ksft_print_msg("Cache span (%s): %zu\n", lines ? "lines" : "bytes",
cache_span); cache_span);
} }
...@@ -41,12 +41,12 @@ static int cat_setup(struct resctrl_val_param *p) ...@@ -41,12 +41,12 @@ static int cat_setup(struct resctrl_val_param *p)
return ret; return ret;
} }
static int show_results_info(unsigned long sum_llc_val, int no_of_bits, static int show_results_info(__u64 sum_llc_val, int no_of_bits,
unsigned long cache_span, unsigned long max_diff, unsigned long cache_span, unsigned long max_diff,
unsigned long max_diff_percent, unsigned long num_of_runs, unsigned long max_diff_percent, unsigned long num_of_runs,
bool platform) bool platform)
{ {
unsigned long avg_llc_val = 0; __u64 avg_llc_val = 0;
float diff_percent; float diff_percent;
int ret; int ret;
...@@ -68,8 +68,8 @@ static int show_results_info(unsigned long sum_llc_val, int no_of_bits, ...@@ -68,8 +68,8 @@ static int show_results_info(unsigned long sum_llc_val, int no_of_bits,
static int check_results(struct resctrl_val_param *param, size_t span) static int check_results(struct resctrl_val_param *param, size_t span)
{ {
char *token_array[8], temp[512]; char *token_array[8], temp[512];
unsigned long sum_llc_perf_miss = 0;
int runs = 0, no_of_bits = 0; int runs = 0, no_of_bits = 0;
__u64 sum_llc_perf_miss = 0;
FILE *fp; FILE *fp;
ksft_print_msg("Checking for pass/fail\n"); ksft_print_msg("Checking for pass/fail\n");
...@@ -93,7 +93,7 @@ static int check_results(struct resctrl_val_param *param, size_t span) ...@@ -93,7 +93,7 @@ static int check_results(struct resctrl_val_param *param, size_t span)
* setup transition phase. * setup transition phase.
*/ */
if (runs > 0) if (runs > 0)
sum_llc_perf_miss += strtoul(token_array[3], NULL, 0); sum_llc_perf_miss += strtoull(token_array[3], NULL, 0);
runs++; runs++;
} }
......
...@@ -113,8 +113,7 @@ unsigned int count_bits(unsigned long n); ...@@ -113,8 +113,7 @@ unsigned int count_bits(unsigned long n);
void cmt_test_cleanup(void); void cmt_test_cleanup(void);
int get_core_sibling(int cpu_no); int get_core_sibling(int cpu_no);
int measure_llc_resctrl(const char *filename, int bm_pid); int measure_llc_resctrl(const char *filename, int bm_pid);
void show_cache_info(int no_of_bits, unsigned long avg_llc_val, void show_cache_info(int no_of_bits, __u64 avg_llc_val, size_t cache_span, bool lines);
size_t cache_span, bool lines);
/* /*
* cache_portion_size - Calculate the size of a cache portion * cache_portion_size - Calculate the size of a cache portion
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment