Commit 334b4f98 authored by Javed Hasan's avatar Javed Hasan Committed by Martin K. Petersen

scsi: qedf: Acquire rport_lock for resetting the delay_timestamp

Retry delay timestamp is updated in queuecommand as well as in
qedf_scsi_completion routine. Protect it using lock.

Link: https://lore.kernel.org/r/20200416084314.18851-4-skashyap@marvell.comSigned-off-by: default avatarJaved Hasan <jhasan@marvell.com>
Signed-off-by: default avatarSaurav Kashyap <skashyap@marvell.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent b0c4187e
...@@ -1021,14 +1021,18 @@ qedf_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc_cmd) ...@@ -1021,14 +1021,18 @@ qedf_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *sc_cmd)
atomic_inc(&fcport->ios_to_queue); atomic_inc(&fcport->ios_to_queue);
if (fcport->retry_delay_timestamp) { if (fcport->retry_delay_timestamp) {
/* Take fcport->rport_lock for resetting the delay_timestamp */
spin_lock_irqsave(&fcport->rport_lock, flags);
if (time_after(jiffies, fcport->retry_delay_timestamp)) { if (time_after(jiffies, fcport->retry_delay_timestamp)) {
fcport->retry_delay_timestamp = 0; fcport->retry_delay_timestamp = 0;
} else { } else {
spin_unlock_irqrestore(&fcport->rport_lock, flags);
/* If retry_delay timer is active, flow off the ML */ /* If retry_delay timer is active, flow off the ML */
rc = SCSI_MLQUEUE_TARGET_BUSY; rc = SCSI_MLQUEUE_TARGET_BUSY;
atomic_dec(&fcport->ios_to_queue); atomic_dec(&fcport->ios_to_queue);
goto exit_qcmd; goto exit_qcmd;
} }
spin_unlock_irqrestore(&fcport->rport_lock, flags);
} }
io_req = qedf_alloc_cmd(fcport, QEDF_SCSI_CMD); io_req = qedf_alloc_cmd(fcport, QEDF_SCSI_CMD);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment