Commit 34a89b8c authored by Ajit Khaparde's avatar Ajit Khaparde Committed by David S. Miller

be2net: bug fix in be_change_mtu

Current code allows the new mtu to cross the supported value.
This patch fixes the boundary checks.

From: Suresh R <sureshr@serverengines.com>
Signed-off-by: default avatarAjit Khaparde <ajitk@serverengines.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3f0d4560
...@@ -473,10 +473,12 @@ static int be_change_mtu(struct net_device *netdev, int new_mtu) ...@@ -473,10 +473,12 @@ static int be_change_mtu(struct net_device *netdev, int new_mtu)
{ {
struct be_adapter *adapter = netdev_priv(netdev); struct be_adapter *adapter = netdev_priv(netdev);
if (new_mtu < BE_MIN_MTU || if (new_mtu < BE_MIN_MTU ||
new_mtu > BE_MAX_JUMBO_FRAME_SIZE) { new_mtu > (BE_MAX_JUMBO_FRAME_SIZE -
(ETH_HLEN + ETH_FCS_LEN))) {
dev_info(&adapter->pdev->dev, dev_info(&adapter->pdev->dev,
"MTU must be between %d and %d bytes\n", "MTU must be between %d and %d bytes\n",
BE_MIN_MTU, BE_MAX_JUMBO_FRAME_SIZE); BE_MIN_MTU,
(BE_MAX_JUMBO_FRAME_SIZE - (ETH_HLEN + ETH_FCS_LEN)));
return -EINVAL; return -EINVAL;
} }
dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n", dev_info(&adapter->pdev->dev, "MTU changed from %d to %d bytes\n",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment