Commit 34ca0066 authored by Dave Jiang's avatar Dave Jiang Committed by Vinod Koul

dmaengine: idxd: reformat swerror output to standard Linux bitmap output

SWERROR register is 4 64bit wide registers. Currently the sysfs attribute
just outputs 4 64bit hex integers. Convert to output with %*pb format
specifier.
Signed-off-by: default avatarDave Jiang <dave.jiang@intel.com>
Co-developed-by: default avatarFenghua Yu <fenghua.yu@intel.com>
Signed-off-by: default avatarFenghua Yu <fenghua.yu@intel.com>
Link: https://lore.kernel.org/r/20230303213732.3357494-2-fenghua.yu@intel.comSigned-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 6fec8938
...@@ -598,6 +598,7 @@ int idxd_register_driver(void); ...@@ -598,6 +598,7 @@ int idxd_register_driver(void);
void idxd_unregister_driver(void); void idxd_unregister_driver(void);
void idxd_wqs_quiesce(struct idxd_device *idxd); void idxd_wqs_quiesce(struct idxd_device *idxd);
bool idxd_queue_int_handle_resubmit(struct idxd_desc *desc); bool idxd_queue_int_handle_resubmit(struct idxd_desc *desc);
void multi_u64_to_bmap(unsigned long *bmap, u64 *val, int count);
/* device interrupt control */ /* device interrupt control */
irqreturn_t idxd_misc_thread(int vec, void *data); irqreturn_t idxd_misc_thread(int vec, void *data);
......
...@@ -388,7 +388,7 @@ static void idxd_read_table_offsets(struct idxd_device *idxd) ...@@ -388,7 +388,7 @@ static void idxd_read_table_offsets(struct idxd_device *idxd)
dev_dbg(dev, "IDXD Perfmon Offset: %#x\n", idxd->perfmon_offset); dev_dbg(dev, "IDXD Perfmon Offset: %#x\n", idxd->perfmon_offset);
} }
static void multi_u64_to_bmap(unsigned long *bmap, u64 *val, int count) void multi_u64_to_bmap(unsigned long *bmap, u64 *val, int count)
{ {
int i, j, nr; int i, j, nr;
......
...@@ -1452,15 +1452,13 @@ static ssize_t errors_show(struct device *dev, ...@@ -1452,15 +1452,13 @@ static ssize_t errors_show(struct device *dev,
struct device_attribute *attr, char *buf) struct device_attribute *attr, char *buf)
{ {
struct idxd_device *idxd = confdev_to_idxd(dev); struct idxd_device *idxd = confdev_to_idxd(dev);
int i, out = 0; DECLARE_BITMAP(swerr_bmap, 256);
bitmap_zero(swerr_bmap, 256);
spin_lock(&idxd->dev_lock); spin_lock(&idxd->dev_lock);
for (i = 0; i < 4; i++) multi_u64_to_bmap(swerr_bmap, &idxd->sw_err.bits[0], 4);
out += sysfs_emit_at(buf, out, "%#018llx ", idxd->sw_err.bits[i]);
spin_unlock(&idxd->dev_lock); spin_unlock(&idxd->dev_lock);
out--; return sysfs_emit(buf, "%*pb\n", 256, swerr_bmap);
out += sysfs_emit_at(buf, out, "\n");
return out;
} }
static DEVICE_ATTR_RO(errors); static DEVICE_ATTR_RO(errors);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment