Commit 35039eb6 authored by Masami Hiramatsu's avatar Masami Hiramatsu Committed by Ingo Molnar

x86: Show symbol name if insn decoder test failed

Show symbol name if insn decoder test find a difference.
This will help us to find out where the issue is.
Signed-off-by: default avatarMasami Hiramatsu <mhiramat@redhat.com>
Cc: systemtap <systemtap@sources.redhat.com>
Cc: DLE <dle-develop@lists.sourceforge.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
LKML-Reference: <20091116230624.5250.49813.stgit@harusame>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent d65ff75f
...@@ -15,6 +15,11 @@ BEGIN { ...@@ -15,6 +15,11 @@ BEGIN {
fwait_str="9b\tfwait" fwait_str="9b\tfwait"
} }
/^ *[0-9a-f]+ <[^>]*>:/ {
# Symbol entry
printf("%s%s\n", $2, $1)
}
/^ *[0-9a-f]+:/ { /^ *[0-9a-f]+:/ {
if (split($0, field, "\t") < 3) { if (split($0, field, "\t") < 3) {
# This is a continuation of the same insn. # This is a continuation of the same insn.
......
...@@ -110,7 +110,7 @@ static void parse_args(int argc, char **argv) ...@@ -110,7 +110,7 @@ static void parse_args(int argc, char **argv)
int main(int argc, char **argv) int main(int argc, char **argv)
{ {
char line[BUFSIZE]; char line[BUFSIZE], sym[BUFSIZE] = "<unknown>";
unsigned char insn_buf[16]; unsigned char insn_buf[16];
struct insn insn; struct insn insn;
int insns = 0, c; int insns = 0, c;
...@@ -122,6 +122,12 @@ int main(int argc, char **argv) ...@@ -122,6 +122,12 @@ int main(int argc, char **argv)
int nb = 0; int nb = 0;
unsigned int b; unsigned int b;
if (line[0] == '<') {
/* Symbol line */
strcpy(sym, line);
continue;
}
insns++; insns++;
memset(insn_buf, 0, 16); memset(insn_buf, 0, 16);
strcpy(copy, line); strcpy(copy, line);
...@@ -145,6 +151,8 @@ int main(int argc, char **argv) ...@@ -145,6 +151,8 @@ int main(int argc, char **argv)
insn_init(&insn, insn_buf, x86_64); insn_init(&insn, insn_buf, x86_64);
insn_get_length(&insn); insn_get_length(&insn);
if (insn.length != nb) { if (insn.length != nb) {
fprintf(stderr, "Error: %s found a difference at %s\n",
prog, sym);
fprintf(stderr, "Error: %s", line); fprintf(stderr, "Error: %s", line);
fprintf(stderr, "Error: objdump says %d bytes, but " fprintf(stderr, "Error: objdump says %d bytes, but "
"insn_get_length() says %d\n", nb, "insn_get_length() says %d\n", nb,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment