Commit 3665f381 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller

net: do not read sk_drops if application does not care

sk_drops can be an often written field, do not read it unless
application showed interest.

Note that sk_drops can be read via inet_diag, so applications
can avoid getting this info from every received packet.

In the future, 'reading' sk_drops might require folding per node or per
cpu fields, and thus become even more expensive than today.
Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Cc: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c8c8b127
...@@ -2163,7 +2163,8 @@ struct sock_skb_cb { ...@@ -2163,7 +2163,8 @@ struct sock_skb_cb {
static inline void static inline void
sock_skb_set_dropcount(const struct sock *sk, struct sk_buff *skb) sock_skb_set_dropcount(const struct sock *sk, struct sk_buff *skb)
{ {
SOCK_SKB_CB(skb)->dropcount = atomic_read(&sk->sk_drops); SOCK_SKB_CB(skb)->dropcount = sock_flag(sk, SOCK_RXQ_OVFL) ?
atomic_read(&sk->sk_drops) : 0;
} }
static inline void sk_drops_add(struct sock *sk, const struct sk_buff *skb) static inline void sk_drops_add(struct sock *sk, const struct sk_buff *skb)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment