Commit 36dd9bb5 authored by Avi Kivity's avatar Avi Kivity

KVM: x86 emulator: rename decode_cache::eip to _eip

The name eip conflicts with a field of the same name in x86_emulate_ctxt,
which we plan to fold decode_cache into.

The name _eip is unfortunate, but what's really needed is a refactoring
here, not a better name.
Signed-off-by: default avatarAvi Kivity <avi@redhat.com>
Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
parent 2e4ce7f5
...@@ -253,7 +253,7 @@ struct decode_cache { ...@@ -253,7 +253,7 @@ struct decode_cache {
u8 modrm_rm; u8 modrm_rm;
u8 modrm_seg; u8 modrm_seg;
bool rip_relative; bool rip_relative;
unsigned long eip; unsigned long _eip;
/* Fields above regs are cleared together. */ /* Fields above regs are cleared together. */
unsigned long regs[NR_VCPU_REGS]; unsigned long regs[NR_VCPU_REGS];
struct fetch_cache fetch; struct fetch_cache fetch;
......
This diff is collapsed.
...@@ -677,7 +677,7 @@ TRACE_EVENT(kvm_emulate_insn, ...@@ -677,7 +677,7 @@ TRACE_EVENT(kvm_emulate_insn,
TP_fast_assign( TP_fast_assign(
__entry->rip = vcpu->arch.emulate_ctxt.decode.fetch.start; __entry->rip = vcpu->arch.emulate_ctxt.decode.fetch.start;
__entry->csbase = kvm_x86_ops->get_segment_base(vcpu, VCPU_SREG_CS); __entry->csbase = kvm_x86_ops->get_segment_base(vcpu, VCPU_SREG_CS);
__entry->len = vcpu->arch.emulate_ctxt.decode.eip __entry->len = vcpu->arch.emulate_ctxt.decode._eip
- vcpu->arch.emulate_ctxt.decode.fetch.start; - vcpu->arch.emulate_ctxt.decode.fetch.start;
memcpy(__entry->insn, memcpy(__entry->insn,
vcpu->arch.emulate_ctxt.decode.fetch.data, vcpu->arch.emulate_ctxt.decode.fetch.data,
......
...@@ -4560,13 +4560,13 @@ int kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip) ...@@ -4560,13 +4560,13 @@ int kvm_inject_realmode_interrupt(struct kvm_vcpu *vcpu, int irq, int inc_eip)
c->op_bytes = 2; c->op_bytes = 2;
c->ad_bytes = 2; c->ad_bytes = 2;
c->eip = ctxt->eip + inc_eip; c->_eip = ctxt->eip + inc_eip;
ret = emulate_int_real(ctxt, irq); ret = emulate_int_real(ctxt, irq);
if (ret != X86EMUL_CONTINUE) if (ret != X86EMUL_CONTINUE)
return EMULATE_FAIL; return EMULATE_FAIL;
ctxt->eip = c->eip; ctxt->eip = c->_eip;
memcpy(vcpu->arch.regs, c->regs, sizeof c->regs); memcpy(vcpu->arch.regs, c->regs, sizeof c->regs);
kvm_rip_write(vcpu, ctxt->eip); kvm_rip_write(vcpu, ctxt->eip);
kvm_set_rflags(vcpu, ctxt->eflags); kvm_set_rflags(vcpu, ctxt->eflags);
...@@ -4661,7 +4661,7 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu, ...@@ -4661,7 +4661,7 @@ int x86_emulate_instruction(struct kvm_vcpu *vcpu,
} }
if (emulation_type & EMULTYPE_SKIP) { if (emulation_type & EMULTYPE_SKIP) {
kvm_rip_write(vcpu, c->eip); kvm_rip_write(vcpu, c->_eip);
return EMULATE_DONE; return EMULATE_DONE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment