Commit 3813ff8b authored by Julia Lawall's avatar Julia Lawall Committed by Wim Van Sebroeck

watchdog: via_wdt: replace del_timer by del_timer_sync

Use del_timer_sync to ensure that the timer is stopped on all CPUs before
the driver exits.

This change was suggested by Thomas Gleixner.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier i,t,ex;
@@
struct t i = { .remove = ex, };

@@
identifier r.ex;
@@
ex(...) {
  <...
- del_timer
+ del_timer_sync
    (...)
  ...>
}
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 1e8c8a5b
...@@ -232,7 +232,7 @@ static int wdt_probe(struct pci_dev *pdev, ...@@ -232,7 +232,7 @@ static int wdt_probe(struct pci_dev *pdev,
static void wdt_remove(struct pci_dev *pdev) static void wdt_remove(struct pci_dev *pdev)
{ {
watchdog_unregister_device(&wdt_dev); watchdog_unregister_device(&wdt_dev);
del_timer(&timer); del_timer_sync(&timer);
iounmap(wdt_mem); iounmap(wdt_mem);
release_mem_region(mmio, VIA_WDT_MMIO_LEN); release_mem_region(mmio, VIA_WDT_MMIO_LEN);
release_resource(&wdt_res); release_resource(&wdt_res);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment