Commit 38bd221a authored by Mark Brown's avatar Mark Brown Committed by Takashi Iwai

kselftest/alsa - pcm-test: Don't include diagnostic message in test name

When reporting errors or skips we currently include the diagnostic message
indicating why we're failing or skipping. This isn't ideal since KTAP
defines the entire print as the test name, so if there's an error then test
systems won't detect the test as being the same one as a passing test. Move
the diagnostic to a separate ksft_print_msg() to avoid this issue, the test
name part will always be the same for passes, fails and skips and the
diagnostic information is still displayed.
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230323-alsa-pcm-test-names-v1-1-8be67a8885ff@kernel.orgSigned-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 05a2cdfe
......@@ -499,17 +499,18 @@ static void test_pcm_time(struct pcm_data *data, enum test_class class,
}
if (!skip)
ksft_test_result(pass, "%s.%s.%d.%d.%d.%s%s%s\n",
ksft_test_result(pass, "%s.%s.%d.%d.%d.%s\n",
test_class_name, test_name,
data->card, data->device, data->subdevice,
snd_pcm_stream_name(data->stream),
msg[0] ? " " : "", msg);
snd_pcm_stream_name(data->stream));
else
ksft_test_result_skip("%s.%s.%d.%d.%d.%s%s%s\n",
ksft_test_result_skip("%s.%s.%d.%d.%d.%s\n",
test_class_name, test_name,
data->card, data->device, data->subdevice,
snd_pcm_stream_name(data->stream),
msg[0] ? " " : "", msg);
snd_pcm_stream_name(data->stream));
if (msg[0])
ksft_print_msg("%s\n", msg);
pthread_mutex_unlock(&results_lock);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment