Commit 3a6e8454 authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Stephen Boyd

clk: change sizeof(struct clk *) to sizeof(*core->parents)

Now, the clock parent is not "struct clk *", but "struct clk_core *".
Of course, the size of a pointer is always same, but strictly speaking,
sizeof(struct clk *) should be sizeof(struct clk_core *) here.

This mismatch happened when we split the structure into struct clk
and struct clk_core.  For the potential possibility of future renaming,
sizeof(*core->parents) would be better.
Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: default avatarVladimir Zapolskiy <vz@mleia.com>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
parent 027f942c
...@@ -1069,7 +1069,7 @@ static int clk_fetch_parent_index(struct clk_core *core, ...@@ -1069,7 +1069,7 @@ static int clk_fetch_parent_index(struct clk_core *core,
if (!core->parents) { if (!core->parents) {
core->parents = kcalloc(core->num_parents, core->parents = kcalloc(core->num_parents,
sizeof(struct clk *), GFP_KERNEL); sizeof(*core->parents), GFP_KERNEL);
if (!core->parents) if (!core->parents)
return -ENOMEM; return -ENOMEM;
} }
...@@ -1720,7 +1720,7 @@ static struct clk_core *__clk_init_parent(struct clk_core *core) ...@@ -1720,7 +1720,7 @@ static struct clk_core *__clk_init_parent(struct clk_core *core)
if (!core->parents) if (!core->parents)
core->parents = core->parents =
kcalloc(core->num_parents, sizeof(struct clk *), kcalloc(core->num_parents, sizeof(*core->parents),
GFP_KERNEL); GFP_KERNEL);
ret = clk_core_get_parent_by_index(core, index); ret = clk_core_get_parent_by_index(core, index);
...@@ -2368,8 +2368,8 @@ static int __clk_core_init(struct clk_core *core) ...@@ -2368,8 +2368,8 @@ static int __clk_core_init(struct clk_core *core)
* necessary. * necessary.
*/ */
if (core->num_parents > 1) { if (core->num_parents > 1) {
core->parents = kcalloc(core->num_parents, sizeof(struct clk *), core->parents = kcalloc(core->num_parents,
GFP_KERNEL); sizeof(*core->parents), GFP_KERNEL);
/* /*
* clk_core_lookup returns NULL for parents that have not been * clk_core_lookup returns NULL for parents that have not been
* clk_init'd; thus any access to clk->parents[] must check * clk_init'd; thus any access to clk->parents[] must check
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment