Commit 3ae30f4c authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller

of_mdio: fix device reference leak in of_phy_find_device

Make sure to drop the reference taken by bus_find_device() before
returning NULL from of_phy_find_device() when the found device is not a
PHY.

Fixes: 6ed74236 ("of: of_mdio: Ensure mdio device is a PHY")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 48c1699d
...@@ -292,6 +292,7 @@ struct phy_device *of_phy_find_device(struct device_node *phy_np) ...@@ -292,6 +292,7 @@ struct phy_device *of_phy_find_device(struct device_node *phy_np)
mdiodev = to_mdio_device(d); mdiodev = to_mdio_device(d);
if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY) if (mdiodev->flags & MDIO_DEVICE_FLAG_PHY)
return to_phy_device(d); return to_phy_device(d);
put_device(d);
} }
return NULL; return NULL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment