Commit 3bf3eb2b authored by Wei Yongjun's avatar Wei Yongjun Committed by Mark Brown

spi: bcm-qspi: Fix return value check in bcm_qspi_probe()

In case of error, the function kcalloc() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: fa236a7e ("spi: bcm-qspi: Add Broadcom MSPI driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a0319f8b
......@@ -1174,8 +1174,8 @@ int bcm_qspi_probe(struct platform_device *pdev,
qspi->dev_ids = kcalloc(num_irqs, sizeof(struct bcm_qspi_dev_id),
GFP_KERNEL);
if (IS_ERR(qspi->dev_ids)) {
ret = PTR_ERR(qspi->dev_ids);
if (!qspi->dev_ids) {
ret = -ENOMEM;
goto qspi_probe_err;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment