Commit 3c20ba5f authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Vinod Koul

dmaengine: mmp-tdma: fix terminate_all return code

In a recent cleanup, the mmp_tdma_terminate_all function was
introduced but does not set a proper return value. Almost
no slave driver uses that return value, but if one does, the
result will be undefined, which the compiler warns about:

dma/mmp_tdma.c: In function 'mmp_tdma_terminate_all':
dma/mmp_tdma.c:474:1: warning: no return statement in function returning non-void [-Wreturn-type]

This changes the driver to return zero, like most other
drivers do.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Fixes: f43a6fd4 ("dmaengine: mmp-tdma: Split device_control")
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 2f56eaff
...@@ -471,6 +471,8 @@ static int mmp_tdma_terminate_all(struct dma_chan *chan) ...@@ -471,6 +471,8 @@ static int mmp_tdma_terminate_all(struct dma_chan *chan)
mmp_tdma_disable_chan(chan); mmp_tdma_disable_chan(chan);
/* disable interrupt */ /* disable interrupt */
mmp_tdma_enable_irq(tdmac, false); mmp_tdma_enable_irq(tdmac, false);
return 0;
} }
static int mmp_tdma_config(struct dma_chan *chan, static int mmp_tdma_config(struct dma_chan *chan,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment