Commit 3d8f9308 authored by Yevgeny Petrilin's avatar Yevgeny Petrilin Committed by David S. Miller

mlx4: Setting new port types after all interfaces unregistered

In port type change flow, need to set the new port types only after
all interfaces have finished the unregister process.
Otherwise, during unregister, one of the interfaces might issue a SET_PORT
command with wrong port types, it can cause bad FW behavior.
Signed-off-by: default avatarYevgeny Petrilin <yevgenyp@mellanox.co.il>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 730c41d5
...@@ -531,15 +531,14 @@ int mlx4_change_port_types(struct mlx4_dev *dev, ...@@ -531,15 +531,14 @@ int mlx4_change_port_types(struct mlx4_dev *dev,
for (port = 0; port < dev->caps.num_ports; port++) { for (port = 0; port < dev->caps.num_ports; port++) {
/* Change the port type only if the new type is different /* Change the port type only if the new type is different
* from the current, and not set to Auto */ * from the current, and not set to Auto */
if (port_types[port] != dev->caps.port_type[port + 1]) { if (port_types[port] != dev->caps.port_type[port + 1])
change = 1; change = 1;
dev->caps.port_type[port + 1] = port_types[port];
}
} }
if (change) { if (change) {
mlx4_unregister_device(dev); mlx4_unregister_device(dev);
for (port = 1; port <= dev->caps.num_ports; port++) { for (port = 1; port <= dev->caps.num_ports; port++) {
mlx4_CLOSE_PORT(dev, port); mlx4_CLOSE_PORT(dev, port);
dev->caps.port_type[port + 1] = port_types[port];
err = mlx4_SET_PORT(dev, port); err = mlx4_SET_PORT(dev, port);
if (err) { if (err) {
mlx4_err(dev, "Failed to set port %d, " mlx4_err(dev, "Failed to set port %d, "
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment