Commit 3ee859e3 authored by OGAWA Hirofumi's avatar OGAWA Hirofumi Committed by Jens Axboe

block: Fix wrong offset in bio_truncate()

bio_truncate() clears the buffer outside of last block of bdev, however
current bio_truncate() is using the wrong offset of page. So it can
return the uninitialized data.

This happened when both of truncated/corrupted FS and userspace (via
bdev) are trying to read the last of bdev.

Reported-by: syzbot+ac94ae5f68b84197f41c@syzkaller.appspotmail.com
Signed-off-by: default avatarOGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/875yqt1c9g.fsf@mail.parknet.co.jpSigned-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent fd9f4e62
...@@ -569,7 +569,8 @@ static void bio_truncate(struct bio *bio, unsigned new_size) ...@@ -569,7 +569,8 @@ static void bio_truncate(struct bio *bio, unsigned new_size)
offset = new_size - done; offset = new_size - done;
else else
offset = 0; offset = 0;
zero_user(bv.bv_page, offset, bv.bv_len - offset); zero_user(bv.bv_page, bv.bv_offset + offset,
bv.bv_len - offset);
truncated = true; truncated = true;
} }
done += bv.bv_len; done += bv.bv_len;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment