Commit 3ee9ae74 authored by Petr Štetiar's avatar Petr Štetiar Committed by David S. Miller

of_net: Fix missing of_find_device_by_node ref count drop

of_find_device_by_node takes a reference to the embedded struct device
which needs to be dropped after use.

Fixes: d01f449c ("of_net: add NVMEM support to of_get_mac_address")
Reported-by: default avatarkbuild test robot <lkp@intel.com>
Reported-by: default avatarJulia Lawall <julia.lawall@lip6.fr>
Signed-off-by: default avatarPetr Štetiar <ynezz@true.cz>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent da86f59f
...@@ -60,10 +60,13 @@ static const void *of_get_mac_addr_nvmem(struct device_node *np) ...@@ -60,10 +60,13 @@ static const void *of_get_mac_addr_nvmem(struct device_node *np)
return ERR_PTR(-ENODEV); return ERR_PTR(-ENODEV);
ret = nvmem_get_mac_address(&pdev->dev, &nvmem_mac); ret = nvmem_get_mac_address(&pdev->dev, &nvmem_mac);
if (ret) if (ret) {
put_device(&pdev->dev);
return ERR_PTR(ret); return ERR_PTR(ret);
}
mac = devm_kmemdup(&pdev->dev, nvmem_mac, ETH_ALEN, GFP_KERNEL); mac = devm_kmemdup(&pdev->dev, nvmem_mac, ETH_ALEN, GFP_KERNEL);
put_device(&pdev->dev);
if (!mac) if (!mac)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment