Commit 401c90e5 authored by Jesper Juhl's avatar Jesper Juhl Committed by Greg Kroah-Hartman

staging/media/as102: Don't call release_firmware() on uninitialized variable

If, in drivers/staging/media/as102/as102_fw.c::as102_fw_upload(), the call
	cmd_buf = kzalloc(MAX_FW_PKT_SIZE, GFP_KERNEL);
should fail and return NULL so that we jump to the 'error:' label,
then we'll end up calling 'release_firmware(firmware);' with
'firmware' still uninitialized - not good.

The easy fix is to just initialize 'firmware' to NULL when we declare
it, since release_firmware() deals gracefully with being passed NULL
pointers.
Signed-off-by: default avatarJesper Juhl <jj@chaosbits.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 218f4d43
...@@ -165,7 +165,7 @@ static int as102_firmware_upload(struct as10x_bus_adapter_t *bus_adap, ...@@ -165,7 +165,7 @@ static int as102_firmware_upload(struct as10x_bus_adapter_t *bus_adap,
int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap) int as102_fw_upload(struct as10x_bus_adapter_t *bus_adap)
{ {
int errno = -EFAULT; int errno = -EFAULT;
const struct firmware *firmware; const struct firmware *firmware = NULL;
unsigned char *cmd_buf = NULL; unsigned char *cmd_buf = NULL;
char *fw1, *fw2; char *fw1, *fw2;
struct usb_device *dev = bus_adap->usb_dev; struct usb_device *dev = bus_adap->usb_dev;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment