Commit 42318c32 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman

staging: comedi: usbdux: use module_comedi_usb_driver()

Use the module_comedi_usb_driver helper macro to initialize this
module. Rename the driver structs to follow the pattern of the
other comedi driver types and add some whitespace to improve
readability.
Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Cc: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9c3db142
...@@ -317,7 +317,7 @@ static struct usbduxsub usbduxsub[NUMUSBDUX]; ...@@ -317,7 +317,7 @@ static struct usbduxsub usbduxsub[NUMUSBDUX];
static DEFINE_SEMAPHORE(start_stop_sem); static DEFINE_SEMAPHORE(start_stop_sem);
static struct comedi_driver driver_usbdux; /* see below for initializer */ static struct comedi_driver usbdux_driver; /* see below for initializer */
/* /*
* Stops the data acquision * Stops the data acquision
...@@ -2323,7 +2323,7 @@ static void usbdux_firmware_request_complete_handler(const struct firmware *fw, ...@@ -2323,7 +2323,7 @@ static void usbdux_firmware_request_complete_handler(const struct firmware *fw,
"Could not upload firmware (err=%d)\n", ret); "Could not upload firmware (err=%d)\n", ret);
goto out; goto out;
} }
comedi_usb_auto_config(uinterf, &driver_usbdux); comedi_usb_auto_config(uinterf, &usbdux_driver);
out: out:
release_firmware(fw); release_firmware(fw);
} }
...@@ -2832,12 +2832,12 @@ static void usbdux_detach(struct comedi_device *dev) ...@@ -2832,12 +2832,12 @@ static void usbdux_detach(struct comedi_device *dev)
} }
/* main driver struct */ /* main driver struct */
static struct comedi_driver driver_usbdux = { static struct comedi_driver usbdux_driver = {
.driver_name = "usbdux", .driver_name = "usbdux",
.module = THIS_MODULE, .module = THIS_MODULE,
.attach = usbdux_attach, .attach = usbdux_attach,
.detach = usbdux_detach, .detach = usbdux_detach,
.attach_usb = usbdux_attach_usb, .attach_usb = usbdux_attach_usb,
}; };
/* Table with the USB-devices: just now only testing IDs */ /* Table with the USB-devices: just now only testing IDs */
...@@ -2849,35 +2849,13 @@ static const struct usb_device_id usbduxsub_table[] = { ...@@ -2849,35 +2849,13 @@ static const struct usb_device_id usbduxsub_table[] = {
MODULE_DEVICE_TABLE(usb, usbduxsub_table); MODULE_DEVICE_TABLE(usb, usbduxsub_table);
/* The usbduxsub-driver */ static struct usb_driver usbdux_usb_driver = {
static struct usb_driver usbduxsub_driver = { .name = BOARDNAME,
.name = BOARDNAME, .probe = usbduxsub_probe,
.probe = usbduxsub_probe, .disconnect = usbduxsub_disconnect,
.disconnect = usbduxsub_disconnect, .id_table = usbduxsub_table,
.id_table = usbduxsub_table,
}; };
module_comedi_usb_driver(usbdux_driver, usbdux_usb_driver);
/* Can't use the nice macro as I have also to initialise the USB */
/* subsystem: */
/* registering the usb-system _and_ the comedi-driver */
static int __init init_usbdux(void)
{
printk(KERN_INFO KBUILD_MODNAME ": "
DRIVER_VERSION ":" DRIVER_DESC "\n");
usb_register(&usbduxsub_driver);
comedi_driver_register(&driver_usbdux);
return 0;
}
/* deregistering the comedi driver and the usb-subsystem */
static void __exit exit_usbdux(void)
{
comedi_driver_unregister(&driver_usbdux);
usb_deregister(&usbduxsub_driver);
}
module_init(init_usbdux);
module_exit(exit_usbdux);
MODULE_AUTHOR(DRIVER_AUTHOR); MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC); MODULE_DESCRIPTION(DRIVER_DESC);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment