Commit 44ebe791 authored by Wei Wang's avatar Wei Wang Committed by David S. Miller

net: add debug atomic_inc_not_zero() in dst_hold()

This patch is meant to add a debug warning on the situation where dst is
being held during its destroy phase. This could potentially cause double
free issue on the dst.
Signed-off-by: default avatarWei Wang <weiwan@google.com>
Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 1eb04e7c
...@@ -251,7 +251,7 @@ static inline void dst_hold(struct dst_entry *dst) ...@@ -251,7 +251,7 @@ static inline void dst_hold(struct dst_entry *dst)
* __pad_to_align_refcnt declaration in struct dst_entry * __pad_to_align_refcnt declaration in struct dst_entry
*/ */
BUILD_BUG_ON(offsetof(struct dst_entry, __refcnt) & 63); BUILD_BUG_ON(offsetof(struct dst_entry, __refcnt) & 63);
atomic_inc(&dst->__refcnt); WARN_ON(atomic_inc_not_zero(&dst->__refcnt) == 0);
} }
static inline void dst_use(struct dst_entry *dst, unsigned long time) static inline void dst_use(struct dst_entry *dst, unsigned long time)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment