Commit 45c4556d authored by Dan Carpenter's avatar Dan Carpenter Committed by Luis Henriques

intel_scu_ipcutil: underflow in scu_reg_access()

commit b1d353ad upstream.

"count" is controlled by the user and it can be negative.  Let's prevent
that by making it unsigned.  You have to have CAP_SYS_RAWIO to call this
function so the bug is not as serious as it could be.

Fixes: 5369c02d ('intel_scu_ipc: Utility driver for intel scu ipc')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarDarren Hart <dvhart@linux.intel.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent f1da7f50
...@@ -49,7 +49,7 @@ struct scu_ipc_data { ...@@ -49,7 +49,7 @@ struct scu_ipc_data {
static int scu_reg_access(u32 cmd, struct scu_ipc_data *data) static int scu_reg_access(u32 cmd, struct scu_ipc_data *data)
{ {
int count = data->count; unsigned int count = data->count;
if (count == 0 || count == 3 || count > 4) if (count == 0 || count == 3 || count > 4)
return -EINVAL; return -EINVAL;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment