Commit 493f3b15 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe

io_uring: don't take ctx refs in task_work handler

__tctx_task_work() guarantees that ctx won't be killed while running
task_works, so we can remove now unnecessary ctx pinning for internally
armed polling.
Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 45ab03b1
...@@ -4882,7 +4882,6 @@ static int __io_async_wake(struct io_kiocb *req, struct io_poll_iocb *poll, ...@@ -4882,7 +4882,6 @@ static int __io_async_wake(struct io_kiocb *req, struct io_poll_iocb *poll,
req->result = mask; req->result = mask;
req->task_work.func = func; req->task_work.func = func;
percpu_ref_get(&req->ctx->refs);
/* /*
* If this fails, then the task is exiting. When a task exits, the * If this fails, then the task is exiting. When a task exits, the
...@@ -4982,8 +4981,6 @@ static void io_poll_task_func(struct callback_head *cb) ...@@ -4982,8 +4981,6 @@ static void io_poll_task_func(struct callback_head *cb)
if (nxt) if (nxt)
__io_req_task_submit(nxt); __io_req_task_submit(nxt);
} }
percpu_ref_put(&ctx->refs);
} }
static int io_poll_double_wake(struct wait_queue_entry *wait, unsigned mode, static int io_poll_double_wake(struct wait_queue_entry *wait, unsigned mode,
...@@ -5090,7 +5087,6 @@ static void io_async_task_func(struct callback_head *cb) ...@@ -5090,7 +5087,6 @@ static void io_async_task_func(struct callback_head *cb)
if (io_poll_rewait(req, &apoll->poll)) { if (io_poll_rewait(req, &apoll->poll)) {
spin_unlock_irq(&ctx->completion_lock); spin_unlock_irq(&ctx->completion_lock);
percpu_ref_put(&ctx->refs);
return; return;
} }
...@@ -5106,7 +5102,6 @@ static void io_async_task_func(struct callback_head *cb) ...@@ -5106,7 +5102,6 @@ static void io_async_task_func(struct callback_head *cb)
else else
__io_req_task_cancel(req, -ECANCELED); __io_req_task_cancel(req, -ECANCELED);
percpu_ref_put(&ctx->refs);
kfree(apoll->double_poll); kfree(apoll->double_poll);
kfree(apoll); kfree(apoll);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment