Commit 4a679593 authored by Mark Brown's avatar Mark Brown Committed by Masahiro Yamada

kbuild: modpost: Explicitly warn about unprototyped symbols

One common cause of modpost version generation failures is a failure to
prototype exported assembly functions - the tooling requires this for
exported functions even if they are not and should not be called from C
code in order to do the version mangling for symbols. Unfortunately the
error message is currently rather abstruse, simply saying that "version
generation failed" and even diving into the code doesn't directly show
what's going on since there's several steps between the problem and it
being observed.

Provide an explicit hint as to the likely cause of a version generation
failure to help anyone who runs into this in future more readily diagnose
and fix the problem.
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 74ee585b
...@@ -660,8 +660,11 @@ static void handle_modversion(const struct module *mod, ...@@ -660,8 +660,11 @@ static void handle_modversion(const struct module *mod,
unsigned int crc; unsigned int crc;
if (sym->st_shndx == SHN_UNDEF) { if (sym->st_shndx == SHN_UNDEF) {
warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n", warn("EXPORT symbol \"%s\" [%s%s] version ...\n"
symname, mod->name, mod->is_vmlinux ? "" : ".ko"); "Is \"%s\" prototyped in <asm/asm-prototypes.h>?\n",
symname, mod->name, mod->is_vmlinux ? "" : ".ko",
symname);
return; return;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment