Commit 4b00d0c5 authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller

selftests: cmsg_ipv6: repeat the exact packet

cmsg_ipv6 test requests tcpdump to capture 4 packets,
and sends until tcpdump quits. Only the first packet
is "real", however, and the rest are basic UDP packets.
So if tcpdump doesn't start in time it will miss
the real packet and only capture the UDP ones.

This makes the test fail on slow machine (no KVM or with
debug enabled) 100% of the time, while it passes in fast
environments.

Repeat the "real" / expected packet.

Fixes: 9657ad09 ("selftests: net: test IPV6_TCLASS")
Fixes: 05ae83d5 ("selftests: net: test IPV6_HOPLIMIT")
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 38cc3c6d
...@@ -89,7 +89,7 @@ for ovr in setsock cmsg both diff; do ...@@ -89,7 +89,7 @@ for ovr in setsock cmsg both diff; do
check_result $? 0 "TCLASS $prot $ovr - pass" check_result $? 0 "TCLASS $prot $ovr - pass"
while [ -d /proc/$BG ]; do while [ -d /proc/$BG ]; do
$NSEXE ./cmsg_sender -6 -p u $TGT6 1234 $NSEXE ./cmsg_sender -6 -p $p $m $((TOS2)) $TGT6 1234
done done
tcpdump -r $TMPF -v 2>&1 | grep "class $TOS2" >> /dev/null tcpdump -r $TMPF -v 2>&1 | grep "class $TOS2" >> /dev/null
...@@ -126,7 +126,7 @@ for ovr in setsock cmsg both diff; do ...@@ -126,7 +126,7 @@ for ovr in setsock cmsg both diff; do
check_result $? 0 "HOPLIMIT $prot $ovr - pass" check_result $? 0 "HOPLIMIT $prot $ovr - pass"
while [ -d /proc/$BG ]; do while [ -d /proc/$BG ]; do
$NSEXE ./cmsg_sender -6 -p u $TGT6 1234 $NSEXE ./cmsg_sender -6 -p $p $m $LIM $TGT6 1234
done done
tcpdump -r $TMPF -v 2>&1 | grep "hlim $LIM[^0-9]" >> /dev/null tcpdump -r $TMPF -v 2>&1 | grep "hlim $LIM[^0-9]" >> /dev/null
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment