Commit 4cc0d2f4 authored by Miklos Szeredi's avatar Miklos Szeredi Committed by Sasha Levin

vfs: fix uninitialized flags in splice_to_pipe()

[ Upstream commit 5a81e6a1 ]

Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the
unused part of the pipe ring buffer.  Previously splice_to_pipe() left
the flags value alone, which could result in incorrect behavior.

Uninitialized flags appears to have been there from the introduction of
the splice syscall.
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Cc: <stable@vger.kernel.org> # 2.6.17+
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
parent 64c46de9
...@@ -211,6 +211,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe, ...@@ -211,6 +211,7 @@ ssize_t splice_to_pipe(struct pipe_inode_info *pipe,
buf->len = spd->partial[page_nr].len; buf->len = spd->partial[page_nr].len;
buf->private = spd->partial[page_nr].private; buf->private = spd->partial[page_nr].private;
buf->ops = spd->ops; buf->ops = spd->ops;
buf->flags = 0;
if (spd->flags & SPLICE_F_GIFT) if (spd->flags & SPLICE_F_GIFT)
buf->flags |= PIPE_BUF_FLAG_GIFT; buf->flags |= PIPE_BUF_FLAG_GIFT;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment