Commit 4d7f3e75 authored by Neil Armstrong's avatar Neil Armstrong Committed by David S. Miller

net: dsa: exit probe if no switch were found

If no switch were found in dsa_setup_dst, return -ENODEV and
exit the dsa_probe cleanly.
Signed-off-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d4ac35d6
...@@ -837,10 +837,11 @@ static inline void dsa_of_remove(struct device *dev) ...@@ -837,10 +837,11 @@ static inline void dsa_of_remove(struct device *dev)
} }
#endif #endif
static void dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev, static int dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev,
struct device *parent, struct dsa_platform_data *pd) struct device *parent, struct dsa_platform_data *pd)
{ {
int i; int i;
unsigned configured = 0;
dst->pd = pd; dst->pd = pd;
dst->master_netdev = dev; dst->master_netdev = dev;
...@@ -860,8 +861,16 @@ static void dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev, ...@@ -860,8 +861,16 @@ static void dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev,
dst->ds[i] = ds; dst->ds[i] = ds;
if (ds->drv->poll_link != NULL) if (ds->drv->poll_link != NULL)
dst->link_poll_needed = 1; dst->link_poll_needed = 1;
++configured;
} }
/*
* If no switch was found, exit cleanly
*/
if (!configured)
return -EPROBE_DEFER;
/* /*
* If we use a tagging format that doesn't have an ethertype * If we use a tagging format that doesn't have an ethertype
* field, make sure that all packets from this point on get * field, make sure that all packets from this point on get
...@@ -878,6 +887,8 @@ static void dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev, ...@@ -878,6 +887,8 @@ static void dsa_setup_dst(struct dsa_switch_tree *dst, struct net_device *dev,
dst->link_poll_timer.expires = round_jiffies(jiffies + HZ); dst->link_poll_timer.expires = round_jiffies(jiffies + HZ);
add_timer(&dst->link_poll_timer); add_timer(&dst->link_poll_timer);
} }
return 0;
} }
static int dsa_probe(struct platform_device *pdev) static int dsa_probe(struct platform_device *pdev)
...@@ -927,7 +938,9 @@ static int dsa_probe(struct platform_device *pdev) ...@@ -927,7 +938,9 @@ static int dsa_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, dst); platform_set_drvdata(pdev, dst);
dsa_setup_dst(dst, dev, &pdev->dev, pd); ret = dsa_setup_dst(dst, dev, &pdev->dev, pd);
if (ret)
goto out;
return 0; return 0;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment