Commit 4dc7daf8 authored by Dave Gordon's avatar Dave Gordon Committed by Linus Torvalds

lib/scatterlist.c: fix kerneldoc for sg_pcopy_{to,from}_buffer()

The kerneldoc for the functions doesn't match the code; the last two
parameters (buflen, skip) have been transposed, which is confusing,
especially as they're both integral types and the compiler won't warn
about swapping them.

These functions and the kerneldoc were introduced in commit:
    df642cea lib/scatterlist: introduce sg_pcopy_from_buffer() ...
    Author: Akinobu Mita <akinobu.mita@gmail.com>
    Date:   Mon Jul 8 16:01:54 2013 -0700

    The only difference between sg_pcopy_{from,to}_buffer() and
    sg_copy_{from,to}_buffer() is an additional argument that
    specifies the number of bytes to skip the SG list before
    copying.

The functions have the extra argument at the end, but the kerneldoc
lists it in penultimate position.
Signed-off-by: default avatarDave Gordon <david.s.gordon@intel.com>
Reviewed-by: default avatarAkinobu Mita <akinobu.mita@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6157dbbf
...@@ -729,8 +729,8 @@ EXPORT_SYMBOL(sg_copy_to_buffer); ...@@ -729,8 +729,8 @@ EXPORT_SYMBOL(sg_copy_to_buffer);
* @sgl: The SG list * @sgl: The SG list
* @nents: Number of SG entries * @nents: Number of SG entries
* @buf: Where to copy from * @buf: Where to copy from
* @skip: Number of bytes to skip before copying
* @buflen: The number of bytes to copy * @buflen: The number of bytes to copy
* @skip: Number of bytes to skip before copying
* *
* Returns the number of copied bytes. * Returns the number of copied bytes.
* *
...@@ -747,8 +747,8 @@ EXPORT_SYMBOL(sg_pcopy_from_buffer); ...@@ -747,8 +747,8 @@ EXPORT_SYMBOL(sg_pcopy_from_buffer);
* @sgl: The SG list * @sgl: The SG list
* @nents: Number of SG entries * @nents: Number of SG entries
* @buf: Where to copy to * @buf: Where to copy to
* @skip: Number of bytes to skip before copying
* @buflen: The number of bytes to copy * @buflen: The number of bytes to copy
* @skip: Number of bytes to skip before copying
* *
* Returns the number of copied bytes. * Returns the number of copied bytes.
* *
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment