Commit 5026932a authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman

iio: adc: gyroadc: fix uninitialized return code

[ Upstream commit 90c6260c ]

gcc-9 complains about a blatant uninitialized variable use that
all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where
we accidentally return 0 on failure.

Cc: stable@vger.kernel.org
Fixes: 059c53b3 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 2e7e7c8f
...@@ -391,7 +391,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) ...@@ -391,7 +391,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
dev_err(dev, dev_err(dev,
"Only %i channels supported with %s, but reg = <%i>.\n", "Only %i channels supported with %s, but reg = <%i>.\n",
num_channels, child->name, reg); num_channels, child->name, reg);
return ret; return -EINVAL;
} }
} }
...@@ -400,7 +400,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev) ...@@ -400,7 +400,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
dev_err(dev, dev_err(dev,
"Channel %i uses different ADC mode than the rest.\n", "Channel %i uses different ADC mode than the rest.\n",
reg); reg);
return ret; return -EINVAL;
} }
/* Channel is valid, grab the regulator. */ /* Channel is valid, grab the regulator. */
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment