Commit 533c64bc authored by Christian Marangi's avatar Christian Marangi Committed by Jakub Kicinski

net: dsa: qca8k: make mib autocast feature optional

Some switch may not support mib autocast feature and require the legacy
way of reading the regs directly.
Make the mib autocast feature optional and permit to declare support for
it using match_data struct in a dedicated qca8k_info_ops struct.
Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Reviewed-by: default avatarVladimir Oltean <olteanv@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3bb0844e
...@@ -2104,8 +2104,8 @@ qca8k_get_ethtool_stats(struct dsa_switch *ds, int port, ...@@ -2104,8 +2104,8 @@ qca8k_get_ethtool_stats(struct dsa_switch *ds, int port,
u32 hi = 0; u32 hi = 0;
int ret; int ret;
if (priv->mgmt_master && if (priv->mgmt_master && priv->info->ops->autocast_mib &&
qca8k_get_ethtool_stats_eth(ds, port, data) > 0) priv->info->ops->autocast_mib(ds, port, data) > 0)
return; return;
for (i = 0; i < priv->info->mib_count; i++) { for (i = 0; i < priv->info->mib_count; i++) {
...@@ -3243,20 +3243,27 @@ static int qca8k_resume(struct device *dev) ...@@ -3243,20 +3243,27 @@ static int qca8k_resume(struct device *dev)
static SIMPLE_DEV_PM_OPS(qca8k_pm_ops, static SIMPLE_DEV_PM_OPS(qca8k_pm_ops,
qca8k_suspend, qca8k_resume); qca8k_suspend, qca8k_resume);
static const struct qca8k_info_ops qca8xxx_ops = {
.autocast_mib = qca8k_get_ethtool_stats_eth,
};
static const struct qca8k_match_data qca8327 = { static const struct qca8k_match_data qca8327 = {
.id = QCA8K_ID_QCA8327, .id = QCA8K_ID_QCA8327,
.reduced_package = true, .reduced_package = true,
.mib_count = QCA8K_QCA832X_MIB_COUNT, .mib_count = QCA8K_QCA832X_MIB_COUNT,
.ops = &qca8xxx_ops,
}; };
static const struct qca8k_match_data qca8328 = { static const struct qca8k_match_data qca8328 = {
.id = QCA8K_ID_QCA8327, .id = QCA8K_ID_QCA8327,
.mib_count = QCA8K_QCA832X_MIB_COUNT, .mib_count = QCA8K_QCA832X_MIB_COUNT,
.ops = &qca8xxx_ops,
}; };
static const struct qca8k_match_data qca833x = { static const struct qca8k_match_data qca833x = {
.id = QCA8K_ID_QCA8337, .id = QCA8K_ID_QCA8337,
.mib_count = QCA8K_QCA833X_MIB_COUNT, .mib_count = QCA8K_QCA833X_MIB_COUNT,
.ops = &qca8xxx_ops,
}; };
static const struct of_device_id qca8k_of_match[] = { static const struct of_device_id qca8k_of_match[] = {
......
...@@ -324,10 +324,15 @@ enum qca8k_mid_cmd { ...@@ -324,10 +324,15 @@ enum qca8k_mid_cmd {
QCA8K_MIB_CAST = 3, QCA8K_MIB_CAST = 3,
}; };
struct qca8k_info_ops {
int (*autocast_mib)(struct dsa_switch *ds, int port, u64 *data);
};
struct qca8k_match_data { struct qca8k_match_data {
u8 id; u8 id;
bool reduced_package; bool reduced_package;
u8 mib_count; u8 mib_count;
const struct qca8k_info_ops *ops;
}; };
enum { enum {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment