Commit 53a256ea authored by Sven Peter's avatar Sven Peter Committed by Greg Kroah-Hartman

usb: typec: tipd: Move tps6598x_disconnect error path to its own label

While the code currently correctly calls tps6598x_disconnect before jumping
to the error cleanup label it's inconsistent compared to all the other cleanup
actions and prone to introduce bugs if any more resources are added.
Signed-off-by: default avatarSven Peter <sven@svenpeter.dev>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20221114174449.34634-4-sven@svenpeter.devSigned-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4c8f27ba
......@@ -837,16 +837,16 @@ static int tps6598x_probe(struct i2c_client *client)
irq_handler,
IRQF_SHARED | IRQF_ONESHOT,
dev_name(&client->dev), tps);
if (ret) {
tps6598x_disconnect(tps, 0);
goto err_unregister_port;
}
if (ret)
goto err_disconnect;
i2c_set_clientdata(client, tps);
fwnode_handle_put(fwnode);
return 0;
err_disconnect:
tps6598x_disconnect(tps, 0);
err_unregister_port:
typec_unregister_port(tps->port);
err_role_put:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment