Commit 53e720f3 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Felipe Balbi

usb: gadget: udc: add null check before pointer dereference

Add null check before dereferencing dev->regs pointer inside
net2280_led_shutdown() function.

Addresses-Coverity-ID: 101783
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent d94e64cb
...@@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev) ...@@ -3573,7 +3573,6 @@ static void net2280_remove(struct pci_dev *pdev)
BUG_ON(dev->driver); BUG_ON(dev->driver);
/* then clean up the resources we allocated during probe() */ /* then clean up the resources we allocated during probe() */
net2280_led_shutdown(dev);
if (dev->requests) { if (dev->requests) {
int i; int i;
for (i = 1; i < 5; i++) { for (i = 1; i < 5; i++) {
...@@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev) ...@@ -3588,8 +3587,10 @@ static void net2280_remove(struct pci_dev *pdev)
free_irq(pdev->irq, dev); free_irq(pdev->irq, dev);
if (dev->quirks & PLX_PCIE) if (dev->quirks & PLX_PCIE)
pci_disable_msi(pdev); pci_disable_msi(pdev);
if (dev->regs) if (dev->regs) {
net2280_led_shutdown(dev);
iounmap(dev->regs); iounmap(dev->regs);
}
if (dev->region) if (dev->region)
release_mem_region(pci_resource_start(pdev, 0), release_mem_region(pci_resource_start(pdev, 0),
pci_resource_len(pdev, 0)); pci_resource_len(pdev, 0));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment