Commit 54a5d382 authored by Pravin B Shelar's avatar Pravin B Shelar Committed by David S. Miller

ip_tunnel: Fix off-by-one error in forming dev name.

As Ben pointed out following patch fixes bug in checking device
name length limits while forming tunnel device name.

CC: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarPravin B Shelar <pshelar@nicira.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 27815032
...@@ -284,7 +284,7 @@ static struct net_device *__ip_tunnel_create(struct net *net, ...@@ -284,7 +284,7 @@ static struct net_device *__ip_tunnel_create(struct net *net,
if (parms->name[0]) if (parms->name[0])
strlcpy(name, parms->name, IFNAMSIZ); strlcpy(name, parms->name, IFNAMSIZ);
else { else {
if (strlen(ops->kind) + 3 >= IFNAMSIZ) { if (strlen(ops->kind) > (IFNAMSIZ - 3)) {
err = -E2BIG; err = -E2BIG;
goto failed; goto failed;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment