Commit 5518da62 authored by David Edmondson's avatar David Edmondson Committed by Paolo Bonzini

KVM: x86: dump_vmcs should consider only the load controls of EFER/PAT

When deciding whether to dump the GUEST_IA32_EFER and GUEST_IA32_PAT
fields of the VMCS, examine only the VM entry load controls, as saving
on VM exit has no effect on whether VM entry succeeds or fails.
Suggested-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarDavid Edmondson <david.edmondson@oracle.com>
Message-Id: <20210318120841.133123-4-david.edmondson@oracle.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 699e1b2e
...@@ -5771,11 +5771,9 @@ void dump_vmcs(void) ...@@ -5771,11 +5771,9 @@ void dump_vmcs(void)
vmx_dump_sel("LDTR:", GUEST_LDTR_SELECTOR); vmx_dump_sel("LDTR:", GUEST_LDTR_SELECTOR);
vmx_dump_dtsel("IDTR:", GUEST_IDTR_LIMIT); vmx_dump_dtsel("IDTR:", GUEST_IDTR_LIMIT);
vmx_dump_sel("TR: ", GUEST_TR_SELECTOR); vmx_dump_sel("TR: ", GUEST_TR_SELECTOR);
if ((vmexit_ctl & VM_EXIT_SAVE_IA32_EFER) || if (vmentry_ctl & VM_ENTRY_LOAD_IA32_EFER)
(vmentry_ctl & VM_ENTRY_LOAD_IA32_EFER))
pr_err("EFER= 0x%016llx\n", vmcs_read64(GUEST_IA32_EFER)); pr_err("EFER= 0x%016llx\n", vmcs_read64(GUEST_IA32_EFER));
if ((vmexit_ctl & VM_EXIT_SAVE_IA32_PAT) || if (vmentry_ctl & VM_ENTRY_LOAD_IA32_PAT)
(vmentry_ctl & VM_ENTRY_LOAD_IA32_PAT))
pr_err("PAT = 0x%016llx\n", vmcs_read64(GUEST_IA32_PAT)); pr_err("PAT = 0x%016llx\n", vmcs_read64(GUEST_IA32_PAT));
pr_err("DebugCtl = 0x%016llx DebugExceptions = 0x%016lx\n", pr_err("DebugCtl = 0x%016llx DebugExceptions = 0x%016lx\n",
vmcs_read64(GUEST_IA32_DEBUGCTL), vmcs_read64(GUEST_IA32_DEBUGCTL),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment