Commit 56f1f4b2 authored by Linus Torvalds's avatar Linus Torvalds

Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc

Pull sparc fixes from David Miller:

 1) Do serial locking in a way that makes things clear that these are
    IRQ spinlocks.

 2) Conversion to generic idle loop broke first generation Niagara
    machines, need to have %pil interrupts enabled during cpu yield
    hypervisor call.

 3) Do not use magic constants for iterations over tsb tables, from Doug
    Wilson.

 4) Fix erroneous truncation of 64-bit system call return values to
    32-bit.  From Dave Kleikamp.

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc:
  sparc64: Make sure %pil interrupts are enabled during hypervisor yield.
  sparc64:tsb.c:use array size macro rather than number
  sparc64: don't treat 64-bit syscall return codes as 32-bit
  sparc: serial: Clean up the locking for -rt
parents 8a109446 cb3042d6
...@@ -58,9 +58,12 @@ void arch_cpu_idle(void) ...@@ -58,9 +58,12 @@ void arch_cpu_idle(void)
{ {
if (tlb_type != hypervisor) { if (tlb_type != hypervisor) {
touch_nmi_watchdog(); touch_nmi_watchdog();
local_irq_enable();
} else { } else {
unsigned long pstate; unsigned long pstate;
local_irq_enable();
/* The sun4v sleeping code requires that we have PSTATE.IE cleared over /* The sun4v sleeping code requires that we have PSTATE.IE cleared over
* the cpu sleep hypervisor call. * the cpu sleep hypervisor call.
*/ */
...@@ -82,7 +85,6 @@ void arch_cpu_idle(void) ...@@ -82,7 +85,6 @@ void arch_cpu_idle(void)
: "=&r" (pstate) : "=&r" (pstate)
: "i" (PSTATE_IE)); : "i" (PSTATE_IE));
} }
local_irq_enable();
} }
#ifdef CONFIG_HOTPLUG_CPU #ifdef CONFIG_HOTPLUG_CPU
......
...@@ -189,7 +189,8 @@ linux_sparc_syscall32: ...@@ -189,7 +189,8 @@ linux_sparc_syscall32:
mov %i0, %l5 ! IEU1 mov %i0, %l5 ! IEU1
5: call %l7 ! CTI Group brk forced 5: call %l7 ! CTI Group brk forced
srl %i5, 0, %o5 ! IEU1 srl %i5, 0, %o5 ! IEU1
ba,a,pt %xcc, 3f ba,pt %xcc, 3f
sra %o0, 0, %o0
/* Linux native system calls enter here... */ /* Linux native system calls enter here... */
.align 32 .align 32
...@@ -217,7 +218,6 @@ linux_sparc_syscall: ...@@ -217,7 +218,6 @@ linux_sparc_syscall:
3: stx %o0, [%sp + PTREGS_OFF + PT_V9_I0] 3: stx %o0, [%sp + PTREGS_OFF + PT_V9_I0]
ret_sys_call: ret_sys_call:
ldx [%sp + PTREGS_OFF + PT_V9_TSTATE], %g3 ldx [%sp + PTREGS_OFF + PT_V9_TSTATE], %g3
sra %o0, 0, %o0
mov %ulo(TSTATE_XCARRY | TSTATE_ICARRY), %g2 mov %ulo(TSTATE_XCARRY | TSTATE_ICARRY), %g2
sllx %g2, 32, %g2 sllx %g2, 32, %g2
......
...@@ -273,7 +273,7 @@ void __init pgtable_cache_init(void) ...@@ -273,7 +273,7 @@ void __init pgtable_cache_init(void)
prom_halt(); prom_halt();
} }
for (i = 0; i < 8; i++) { for (i = 0; i < ARRAY_SIZE(tsb_cache_names); i++) {
unsigned long size = 8192 << i; unsigned long size = 8192 << i;
const char *name = tsb_cache_names[i]; const char *name = tsb_cache_names[i];
......
...@@ -433,13 +433,10 @@ static void sunhv_console_write_paged(struct console *con, const char *s, unsign ...@@ -433,13 +433,10 @@ static void sunhv_console_write_paged(struct console *con, const char *s, unsign
unsigned long flags; unsigned long flags;
int locked = 1; int locked = 1;
local_irq_save(flags); if (port->sysrq || oops_in_progress)
if (port->sysrq) { locked = spin_trylock_irqsave(&port->lock, flags);
locked = 0; else
} else if (oops_in_progress) { spin_lock_irqsave(&port->lock, flags);
locked = spin_trylock(&port->lock);
} else
spin_lock(&port->lock);
while (n > 0) { while (n > 0) {
unsigned long ra = __pa(con_write_page); unsigned long ra = __pa(con_write_page);
...@@ -470,8 +467,7 @@ static void sunhv_console_write_paged(struct console *con, const char *s, unsign ...@@ -470,8 +467,7 @@ static void sunhv_console_write_paged(struct console *con, const char *s, unsign
} }
if (locked) if (locked)
spin_unlock(&port->lock); spin_unlock_irqrestore(&port->lock, flags);
local_irq_restore(flags);
} }
static inline void sunhv_console_putchar(struct uart_port *port, char c) static inline void sunhv_console_putchar(struct uart_port *port, char c)
...@@ -492,7 +488,10 @@ static void sunhv_console_write_bychar(struct console *con, const char *s, unsig ...@@ -492,7 +488,10 @@ static void sunhv_console_write_bychar(struct console *con, const char *s, unsig
unsigned long flags; unsigned long flags;
int i, locked = 1; int i, locked = 1;
local_irq_save(flags); if (port->sysrq || oops_in_progress)
locked = spin_trylock_irqsave(&port->lock, flags);
else
spin_lock_irqsave(&port->lock, flags);
if (port->sysrq) { if (port->sysrq) {
locked = 0; locked = 0;
} else if (oops_in_progress) { } else if (oops_in_progress) {
...@@ -507,8 +506,7 @@ static void sunhv_console_write_bychar(struct console *con, const char *s, unsig ...@@ -507,8 +506,7 @@ static void sunhv_console_write_bychar(struct console *con, const char *s, unsig
} }
if (locked) if (locked)
spin_unlock(&port->lock); spin_unlock_irqrestore(&port->lock, flags);
local_irq_restore(flags);
} }
static struct console sunhv_console = { static struct console sunhv_console = {
......
...@@ -844,20 +844,16 @@ static void sunsab_console_write(struct console *con, const char *s, unsigned n) ...@@ -844,20 +844,16 @@ static void sunsab_console_write(struct console *con, const char *s, unsigned n)
unsigned long flags; unsigned long flags;
int locked = 1; int locked = 1;
local_irq_save(flags); if (up->port.sysrq || oops_in_progress)
if (up->port.sysrq) { locked = spin_trylock_irqsave(&up->port.lock, flags);
locked = 0; else
} else if (oops_in_progress) { spin_lock_irqsave(&up->port.lock, flags);
locked = spin_trylock(&up->port.lock);
} else
spin_lock(&up->port.lock);
uart_console_write(&up->port, s, n, sunsab_console_putchar); uart_console_write(&up->port, s, n, sunsab_console_putchar);
sunsab_tec_wait(up); sunsab_tec_wait(up);
if (locked) if (locked)
spin_unlock(&up->port.lock); spin_unlock_irqrestore(&up->port.lock, flags);
local_irq_restore(flags);
} }
static int sunsab_console_setup(struct console *con, char *options) static int sunsab_console_setup(struct console *con, char *options)
......
...@@ -1295,13 +1295,10 @@ static void sunsu_console_write(struct console *co, const char *s, ...@@ -1295,13 +1295,10 @@ static void sunsu_console_write(struct console *co, const char *s,
unsigned int ier; unsigned int ier;
int locked = 1; int locked = 1;
local_irq_save(flags); if (up->port.sysrq || oops_in_progress)
if (up->port.sysrq) { locked = spin_trylock_irqsave(&up->port.lock, flags);
locked = 0; else
} else if (oops_in_progress) { spin_lock_irqsave(&up->port.lock, flags);
locked = spin_trylock(&up->port.lock);
} else
spin_lock(&up->port.lock);
/* /*
* First save the UER then disable the interrupts * First save the UER then disable the interrupts
...@@ -1319,8 +1316,7 @@ static void sunsu_console_write(struct console *co, const char *s, ...@@ -1319,8 +1316,7 @@ static void sunsu_console_write(struct console *co, const char *s,
serial_out(up, UART_IER, ier); serial_out(up, UART_IER, ier);
if (locked) if (locked)
spin_unlock(&up->port.lock); spin_unlock_irqrestore(&up->port.lock, flags);
local_irq_restore(flags);
} }
/* /*
......
...@@ -1195,20 +1195,16 @@ sunzilog_console_write(struct console *con, const char *s, unsigned int count) ...@@ -1195,20 +1195,16 @@ sunzilog_console_write(struct console *con, const char *s, unsigned int count)
unsigned long flags; unsigned long flags;
int locked = 1; int locked = 1;
local_irq_save(flags); if (up->port.sysrq || oops_in_progress)
if (up->port.sysrq) { locked = spin_trylock_irqsave(&up->port.lock, flags);
locked = 0; else
} else if (oops_in_progress) { spin_lock_irqsave(&up->port.lock, flags);
locked = spin_trylock(&up->port.lock);
} else
spin_lock(&up->port.lock);
uart_console_write(&up->port, s, count, sunzilog_putchar); uart_console_write(&up->port, s, count, sunzilog_putchar);
udelay(2); udelay(2);
if (locked) if (locked)
spin_unlock(&up->port.lock); spin_unlock_irqrestore(&up->port.lock, flags);
local_irq_restore(flags);
} }
static int __init sunzilog_console_setup(struct console *con, char *options) static int __init sunzilog_console_setup(struct console *con, char *options)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment