Commit 570a82b9 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Mauro Carvalho Chehab

media: i2c: select V4L2_ASYNC where needed

I came across a link failure from randconfig builds:

x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_remove':
ths8200.c:(.text+0x491): undefined reference to `v4l2_async_unregister_subdev'
x86_64-linux-ld: drivers/media/i2c/ths8200.o: in function `ths8200_probe':
ths8200.c:(.text+0xe49): undefined reference to `v4l2_async_register_subdev'
x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_remove':
tw9910.c:(.text+0x467): undefined reference to `v4l2_async_unregister_subdev'
x86_64-linux-ld: drivers/media/i2c/tw9910.o: in function `tw9910_probe':
tw9910.c:(.text+0x1123): undefined reference to `v4l2_async_register_subdev'

These clearly lack a 'select' statement, but I don't know why
this started happening only now. I had a bit of a look around to find
other configs that have the same problem, but could not come up with
a reliable way and found nothing else through experimentation.
It is likely that other symbols like these exist that need an extra
select.
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 112024a3
...@@ -450,6 +450,7 @@ config VIDEO_TW9906 ...@@ -450,6 +450,7 @@ config VIDEO_TW9906
config VIDEO_TW9910 config VIDEO_TW9910
tristate "Techwell TW9910 video decoder" tristate "Techwell TW9910 video decoder"
depends on VIDEO_V4L2 && I2C depends on VIDEO_V4L2 && I2C
select V4L2_ASYNC
help help
Support for Techwell TW9910 NTSC/PAL/SECAM video decoder. Support for Techwell TW9910 NTSC/PAL/SECAM video decoder.
...@@ -611,6 +612,7 @@ menu "Video improvement chips" ...@@ -611,6 +612,7 @@ menu "Video improvement chips"
config VIDEO_UPD64031A config VIDEO_UPD64031A
tristate "NEC Electronics uPD64031A Ghost Reduction" tristate "NEC Electronics uPD64031A Ghost Reduction"
depends on VIDEO_V4L2 && I2C depends on VIDEO_V4L2 && I2C
select V4L2_ASYNC
help help
Support for the NEC Electronics uPD64031A Ghost Reduction Support for the NEC Electronics uPD64031A Ghost Reduction
video chip. It is most often found in NTSC TV cards made for video chip. It is most often found in NTSC TV cards made for
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment