Commit 57f21bf8 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski

net/sched: mqprio: add extack to mqprio_parse_nlattr()

Netlink attribute parsing in mqprio is a minesweeper game, with many
options having the possibility of being passed incorrectly and the user
being none the wiser.

Try to make errors less sour by giving user space some information
regarding what went wrong.
Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFerenc Fejes <fejes@inf.elte.hu>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Acked-by: default avatarJamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 3dd0c16e
...@@ -150,7 +150,8 @@ static const struct nla_policy mqprio_policy[TCA_MQPRIO_MAX + 1] = { ...@@ -150,7 +150,8 @@ static const struct nla_policy mqprio_policy[TCA_MQPRIO_MAX + 1] = {
* TCA_OPTIONS, which are appended right after struct tc_mqprio_qopt. * TCA_OPTIONS, which are appended right after struct tc_mqprio_qopt.
*/ */
static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt, static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt,
struct nlattr *opt) struct nlattr *opt,
struct netlink_ext_ack *extack)
{ {
struct nlattr *nlattr_opt = nla_data(opt) + NLA_ALIGN(sizeof(*qopt)); struct nlattr *nlattr_opt = nla_data(opt) + NLA_ALIGN(sizeof(*qopt));
int nlattr_opt_len = nla_len(opt) - NLA_ALIGN(sizeof(*qopt)); int nlattr_opt_len = nla_len(opt) - NLA_ALIGN(sizeof(*qopt));
...@@ -167,8 +168,11 @@ static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt, ...@@ -167,8 +168,11 @@ static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt,
return err; return err;
} }
if (!qopt->hw) if (!qopt->hw) {
NL_SET_ERR_MSG(extack,
"mqprio TCA_OPTIONS can only contain netlink attributes in hardware mode");
return -EINVAL; return -EINVAL;
}
if (tb[TCA_MQPRIO_MODE]) { if (tb[TCA_MQPRIO_MODE]) {
priv->flags |= TC_MQPRIO_F_MODE; priv->flags |= TC_MQPRIO_F_MODE;
...@@ -181,13 +185,19 @@ static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt, ...@@ -181,13 +185,19 @@ static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt,
} }
if (tb[TCA_MQPRIO_MIN_RATE64]) { if (tb[TCA_MQPRIO_MIN_RATE64]) {
if (priv->shaper != TC_MQPRIO_SHAPER_BW_RATE) if (priv->shaper != TC_MQPRIO_SHAPER_BW_RATE) {
NL_SET_ERR_MSG_ATTR(extack, tb[TCA_MQPRIO_MIN_RATE64],
"min_rate accepted only when shaper is in bw_rlimit mode");
return -EINVAL; return -EINVAL;
}
i = 0; i = 0;
nla_for_each_nested(attr, tb[TCA_MQPRIO_MIN_RATE64], nla_for_each_nested(attr, tb[TCA_MQPRIO_MIN_RATE64],
rem) { rem) {
if (nla_type(attr) != TCA_MQPRIO_MIN_RATE64) if (nla_type(attr) != TCA_MQPRIO_MIN_RATE64) {
NL_SET_ERR_MSG_ATTR(extack, attr,
"Attribute type expected to be TCA_MQPRIO_MIN_RATE64");
return -EINVAL; return -EINVAL;
}
if (i >= qopt->num_tc) if (i >= qopt->num_tc)
break; break;
priv->min_rate[i] = nla_get_u64(attr); priv->min_rate[i] = nla_get_u64(attr);
...@@ -197,13 +207,19 @@ static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt, ...@@ -197,13 +207,19 @@ static int mqprio_parse_nlattr(struct Qdisc *sch, struct tc_mqprio_qopt *qopt,
} }
if (tb[TCA_MQPRIO_MAX_RATE64]) { if (tb[TCA_MQPRIO_MAX_RATE64]) {
if (priv->shaper != TC_MQPRIO_SHAPER_BW_RATE) if (priv->shaper != TC_MQPRIO_SHAPER_BW_RATE) {
NL_SET_ERR_MSG_ATTR(extack, tb[TCA_MQPRIO_MAX_RATE64],
"max_rate accepted only when shaper is in bw_rlimit mode");
return -EINVAL; return -EINVAL;
}
i = 0; i = 0;
nla_for_each_nested(attr, tb[TCA_MQPRIO_MAX_RATE64], nla_for_each_nested(attr, tb[TCA_MQPRIO_MAX_RATE64],
rem) { rem) {
if (nla_type(attr) != TCA_MQPRIO_MAX_RATE64) if (nla_type(attr) != TCA_MQPRIO_MAX_RATE64) {
NL_SET_ERR_MSG_ATTR(extack, attr,
"Attribute type expected to be TCA_MQPRIO_MAX_RATE64");
return -EINVAL; return -EINVAL;
}
if (i >= qopt->num_tc) if (i >= qopt->num_tc)
break; break;
priv->max_rate[i] = nla_get_u64(attr); priv->max_rate[i] = nla_get_u64(attr);
...@@ -252,7 +268,7 @@ static int mqprio_init(struct Qdisc *sch, struct nlattr *opt, ...@@ -252,7 +268,7 @@ static int mqprio_init(struct Qdisc *sch, struct nlattr *opt,
len = nla_len(opt) - NLA_ALIGN(sizeof(*qopt)); len = nla_len(opt) - NLA_ALIGN(sizeof(*qopt));
if (len > 0) { if (len > 0) {
err = mqprio_parse_nlattr(sch, qopt, opt); err = mqprio_parse_nlattr(sch, qopt, opt, extack);
if (err) if (err)
return err; return err;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment