Commit 59d5396a authored by Colin Ian King's avatar Colin Ian King Committed by Peter Zijlstra

x86/events/amd/iommu: Fix sizeof mismatch

An incorrect sizeof is being used, struct attribute ** is not correct,
it should be struct attribute *. Note that since ** is the same size as
* this is not causing any issues.  Improve this fix by using sizeof(*attrs)
as this allows us to not even reference the type of the pointer.

Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
Fixes: 51686546 ("x86/events/amd/iommu: Fix sysfs perf attribute groups")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20201001113900.58889-1-colin.king@canonical.com
parent 80a5ce11
...@@ -379,7 +379,7 @@ static __init int _init_events_attrs(void) ...@@ -379,7 +379,7 @@ static __init int _init_events_attrs(void)
while (amd_iommu_v2_event_descs[i].attr.attr.name) while (amd_iommu_v2_event_descs[i].attr.attr.name)
i++; i++;
attrs = kcalloc(i + 1, sizeof(struct attribute **), GFP_KERNEL); attrs = kcalloc(i + 1, sizeof(*attrs), GFP_KERNEL);
if (!attrs) if (!attrs)
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment