Commit 59d6a29e authored by Samuel Iglesias Gonsalvez's avatar Samuel Iglesias Gonsalvez Committed by Greg Kroah-Hartman

Staging: ipack/devices/ipoctal: remove unneeded lock in IRQ handler

In the rest of the code, the data is protected with spin_lock_irqsave().
Signed-off-by: default avatarSamuel Iglesias Gonsalvez <siglesias@igalia.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bae8bd16
...@@ -299,7 +299,7 @@ static int ipoctal_irq_handler(void *arg) ...@@ -299,7 +299,7 @@ static int ipoctal_irq_handler(void *arg)
ipoctal->nb_bytes[channel] = 0; ipoctal->nb_bytes[channel] = 0;
continue; continue;
} }
spin_lock(&ipoctal->lock[channel]);
value = ipoctal->tty_port[channel].xmit_buf[*pointer_write]; value = ipoctal->tty_port[channel].xmit_buf[*pointer_write];
ipoctal_write_io_reg(ipoctal, ipoctal_write_io_reg(ipoctal,
&ipoctal->chan_regs[channel].u.w.thr, &ipoctal->chan_regs[channel].u.w.thr,
...@@ -309,7 +309,6 @@ static int ipoctal_irq_handler(void *arg) ...@@ -309,7 +309,6 @@ static int ipoctal_irq_handler(void *arg)
(*pointer_write)++; (*pointer_write)++;
*pointer_write = *pointer_write % PAGE_SIZE; *pointer_write = *pointer_write % PAGE_SIZE;
ipoctal->nb_bytes[channel]--; ipoctal->nb_bytes[channel]--;
spin_unlock(&ipoctal->lock[channel]);
if ((ipoctal->nb_bytes[channel] == 0) && if ((ipoctal->nb_bytes[channel] == 0) &&
(waitqueue_active(&ipoctal->queue[channel]))) { (waitqueue_active(&ipoctal->queue[channel]))) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment