Commit 5a0d43c3 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

KVM: return an error code in kvm_vm_ioctl_register_coalesced_mmio()

commit aac5c422 upstream.

If kvm_io_bus_register_dev() fails then it returns success but it should
return an error code.

I also did a little cleanup like removing an impossible NULL test.

Fixes: 2b3c246a ('KVM: Make coalesced mmio use a device per zone')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cc512a4a
...@@ -154,17 +154,13 @@ int kvm_vm_ioctl_register_coalesced_mmio(struct kvm *kvm, ...@@ -154,17 +154,13 @@ int kvm_vm_ioctl_register_coalesced_mmio(struct kvm *kvm,
list_add_tail(&dev->list, &kvm->coalesced_zones); list_add_tail(&dev->list, &kvm->coalesced_zones);
mutex_unlock(&kvm->slots_lock); mutex_unlock(&kvm->slots_lock);
return ret; return 0;
out_free_dev: out_free_dev:
mutex_unlock(&kvm->slots_lock); mutex_unlock(&kvm->slots_lock);
kfree(dev); kfree(dev);
if (dev == NULL) return ret;
return -ENXIO;
return 0;
} }
int kvm_vm_ioctl_unregister_coalesced_mmio(struct kvm *kvm, int kvm_vm_ioctl_unregister_coalesced_mmio(struct kvm *kvm,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment