Commit 5a8a6b89 authored by Jingkui Wang's avatar Jingkui Wang Committed by Dmitry Torokhov

Input: drv260x - fix input device's parent assignment

We were assigning I2C bus controller instead of client as parent device.
Besides being logically wrong, it messed up with devm handling of input
device. As a result we were leaving input device and event node behind
after rmmod-ing the driver, which lead to a kernel oops if one were to
access the event node later.

Let's remove the assignment and rely on devm_input_allocate_device() to
set it up properly for us.
Signed-off-by: default avatarJingkui Wang <jkwang@google.com>
Fixes: 7132fe4f ("Input: drv260x - add TI drv260x haptics driver")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
parent 74c82dae
...@@ -592,7 +592,6 @@ static int drv260x_probe(struct i2c_client *client, ...@@ -592,7 +592,6 @@ static int drv260x_probe(struct i2c_client *client,
} }
haptics->input_dev->name = "drv260x:haptics"; haptics->input_dev->name = "drv260x:haptics";
haptics->input_dev->dev.parent = client->dev.parent;
haptics->input_dev->close = drv260x_close; haptics->input_dev->close = drv260x_close;
input_set_drvdata(haptics->input_dev, haptics); input_set_drvdata(haptics->input_dev, haptics);
input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE); input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment