Commit 5bfffa0c authored by Jia-Ju Bai's avatar Jia-Ju Bai Committed by Mauro Carvalho Chehab

media: pci: ivtv: Replace GFP_ATOMIC with GFP_KERNEL

ivtv_probe() and ivtvfb_init_card() are never called in atomic context.
They call kzalloc() with GFP_ATOMIC, which is not necessary.
GFP_ATOMIC can be replaced with GFP_KERNEL.

This is found by a static analysis tool named DCNS written by myself.
Signed-off-by: default avatarJia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: default avatarHans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent 9d08ba6d
...@@ -999,7 +999,7 @@ static int ivtv_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id) ...@@ -999,7 +999,7 @@ static int ivtv_probe(struct pci_dev *pdev, const struct pci_device_id *pci_id)
int vbi_buf_size; int vbi_buf_size;
struct ivtv *itv; struct ivtv *itv;
itv = kzalloc(sizeof(struct ivtv), GFP_ATOMIC); itv = kzalloc(sizeof(struct ivtv), GFP_KERNEL);
if (itv == NULL) if (itv == NULL)
return -ENOMEM; return -ENOMEM;
itv->pdev = pdev; itv->pdev = pdev;
......
...@@ -1178,7 +1178,7 @@ static int ivtvfb_init_card(struct ivtv *itv) ...@@ -1178,7 +1178,7 @@ static int ivtvfb_init_card(struct ivtv *itv)
} }
itv->osd_info = kzalloc(sizeof(struct osd_info), itv->osd_info = kzalloc(sizeof(struct osd_info),
GFP_ATOMIC|__GFP_NOWARN); GFP_KERNEL|__GFP_NOWARN);
if (itv->osd_info == NULL) { if (itv->osd_info == NULL) {
IVTVFB_ERR("Failed to allocate memory for osd_info\n"); IVTVFB_ERR("Failed to allocate memory for osd_info\n");
return -ENOMEM; return -ENOMEM;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment