Commit 5c5759bc authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Jeff Garzik

[PATCH] de214x.c uses uninitialized pci_dev->irq

Don't use pci_dev->irq until after pci_enable_device().
Andy Esten reported that his NIC stopped working in
2.6.10 because of this problem.
Signed-off-by: default avatarBjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: default avatarJeff Garzik <jgarzik@pobox.com>
parent 88f48c81
......@@ -1960,8 +1960,6 @@ static int __devinit de_init_one (struct pci_dev *pdev,
dev->tx_timeout = de_tx_timeout;
dev->watchdog_timeo = TX_TIMEOUT;
dev->irq = pdev->irq;
de = dev->priv;
de->de21040 = ent->driver_data == 0 ? 1 : 0;
de->pdev = pdev;
......@@ -1997,6 +1995,8 @@ static int __devinit de_init_one (struct pci_dev *pdev,
goto err_out_res;
}
dev->irq = pdev->irq;
/* obtain and check validity of PCI I/O address */
pciaddr = pci_resource_start(pdev, 1);
if (!pciaddr) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment