Commit 5c95ed47 authored by Fabrice Gasnier's avatar Fabrice Gasnier Committed by Russell King

ARM: 8310/1: l2c: Fix prefetch settings dt parsing

Allow prefetch settings overriding by device tree, in case
l2x0_cache_size_of_parse() returns value, prefetch tuning
properties are silently ignored. E.g. arm,double-linefill* and
arm,prefetch*.
This happens for example, when "cache-size" or "cache-sets"
properties haven't been filled in l2c dt node.

Comments from Fabrice Gasnier:

 Allow device tree to override the L2C prefetch settings, even when
 l2x0_cache_size_of_parse() fails to parse the cache geometry due to (eg)
 missing "cache-size" or "cache-sets" properties.
Signed-off-by: default avatarFabrice Gasnier <fabrice.gasnier@st.com>
Reviewed-by: default avatarTomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
parent 6d021b72
...@@ -1131,23 +1131,22 @@ static void __init l2c310_of_parse(const struct device_node *np, ...@@ -1131,23 +1131,22 @@ static void __init l2c310_of_parse(const struct device_node *np,
} }
ret = l2x0_cache_size_of_parse(np, aux_val, aux_mask, &assoc, SZ_512K); ret = l2x0_cache_size_of_parse(np, aux_val, aux_mask, &assoc, SZ_512K);
if (ret) if (!ret) {
return; switch (assoc) {
case 16:
switch (assoc) { *aux_val &= ~L2X0_AUX_CTRL_ASSOC_MASK;
case 16: *aux_val |= L310_AUX_CTRL_ASSOCIATIVITY_16;
*aux_val &= ~L2X0_AUX_CTRL_ASSOC_MASK; *aux_mask &= ~L2X0_AUX_CTRL_ASSOC_MASK;
*aux_val |= L310_AUX_CTRL_ASSOCIATIVITY_16; break;
*aux_mask &= ~L2X0_AUX_CTRL_ASSOC_MASK; case 8:
break; *aux_val &= ~L2X0_AUX_CTRL_ASSOC_MASK;
case 8: *aux_mask &= ~L2X0_AUX_CTRL_ASSOC_MASK;
*aux_val &= ~L2X0_AUX_CTRL_ASSOC_MASK; break;
*aux_mask &= ~L2X0_AUX_CTRL_ASSOC_MASK; default:
break; pr_err("L2C-310 OF cache associativity %d invalid, only 8 or 16 permitted\n",
default: assoc);
pr_err("L2C-310 OF cache associativity %d invalid, only 8 or 16 permitted\n", break;
assoc); }
break;
} }
prefetch = l2x0_saved_regs.prefetch_ctrl; prefetch = l2x0_saved_regs.prefetch_ctrl;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment