Commit 5db9c740 authored by Esben Haabendal's avatar Esben Haabendal Committed by David S. Miller

net: ll_temac: Improve error message on error IRQ

The channel status register value can be very helpful when debugging
SDMA problems.
Signed-off-by: default avatarEsben Haabendal <esben@geanix.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent d6787147
...@@ -886,8 +886,10 @@ static irqreturn_t ll_temac_tx_irq(int irq, void *_ndev) ...@@ -886,8 +886,10 @@ static irqreturn_t ll_temac_tx_irq(int irq, void *_ndev)
if (status & (IRQ_COAL | IRQ_DLY)) if (status & (IRQ_COAL | IRQ_DLY))
temac_start_xmit_done(lp->ndev); temac_start_xmit_done(lp->ndev);
if (status & 0x080) if (status & (IRQ_ERR | IRQ_DMAERR))
dev_err(&ndev->dev, "DMA error 0x%x\n", status); dev_err_ratelimited(&ndev->dev,
"TX error 0x%x TX_CHNL_STS=0x%08x\n",
status, lp->dma_in(lp, TX_CHNL_STS));
return IRQ_HANDLED; return IRQ_HANDLED;
} }
...@@ -904,6 +906,10 @@ static irqreturn_t ll_temac_rx_irq(int irq, void *_ndev) ...@@ -904,6 +906,10 @@ static irqreturn_t ll_temac_rx_irq(int irq, void *_ndev)
if (status & (IRQ_COAL | IRQ_DLY)) if (status & (IRQ_COAL | IRQ_DLY))
ll_temac_recv(lp->ndev); ll_temac_recv(lp->ndev);
if (status & (IRQ_ERR | IRQ_DMAERR))
dev_err_ratelimited(&ndev->dev,
"RX error 0x%x RX_CHNL_STS=0x%08x\n",
status, lp->dma_in(lp, RX_CHNL_STS));
return IRQ_HANDLED; return IRQ_HANDLED;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment