Commit 5e3e6a25 authored by Manfred Spraul's avatar Manfred Spraul Committed by Vojtech Pavlik

[PATCH] remove lock_kernel from fifo_open

Sufficient locking for fifo_open is provided by the inode semaphore.
parent 5b6d433e
...@@ -34,7 +34,6 @@ static int fifo_open(struct inode *inode, struct file *filp) ...@@ -34,7 +34,6 @@ static int fifo_open(struct inode *inode, struct file *filp)
int ret; int ret;
ret = -ERESTARTSYS; ret = -ERESTARTSYS;
lock_kernel();
if (down_interruptible(PIPE_SEM(*inode))) if (down_interruptible(PIPE_SEM(*inode)))
goto err_nolock_nocleanup; goto err_nolock_nocleanup;
...@@ -117,7 +116,6 @@ static int fifo_open(struct inode *inode, struct file *filp) ...@@ -117,7 +116,6 @@ static int fifo_open(struct inode *inode, struct file *filp)
/* Ok! */ /* Ok! */
up(PIPE_SEM(*inode)); up(PIPE_SEM(*inode));
unlock_kernel();
return 0; return 0;
err_rd: err_rd:
...@@ -144,7 +142,6 @@ static int fifo_open(struct inode *inode, struct file *filp) ...@@ -144,7 +142,6 @@ static int fifo_open(struct inode *inode, struct file *filp)
up(PIPE_SEM(*inode)); up(PIPE_SEM(*inode));
err_nolock_nocleanup: err_nolock_nocleanup:
unlock_kernel();
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment