Commit 61b8584a authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab

media: mantis: fix two smatch errors

Drop two dprintk's that relied on a non-NULL mantis pointer
when it was in fact a NULL pointer.

Fix those warnings:

drivers/media/pci/mantis/mantis_cards.c:73 mantis_irq_handler() error: we previously assumed 'mantis' could be null (see line 72)
drivers/media/pci/mantis/hopper_cards.c:64 hopper_irq_handler() error: we previously assumed 'mantis' could be null (see line 63)
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@kernel.org>
parent b5f72a17
...@@ -60,10 +60,8 @@ static irqreturn_t hopper_irq_handler(int irq, void *dev_id) ...@@ -60,10 +60,8 @@ static irqreturn_t hopper_irq_handler(int irq, void *dev_id)
struct mantis_ca *ca; struct mantis_ca *ca;
mantis = (struct mantis_pci *) dev_id; mantis = (struct mantis_pci *) dev_id;
if (unlikely(!mantis)) { if (unlikely(!mantis))
dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
return IRQ_NONE; return IRQ_NONE;
}
ca = mantis->mantis_ca; ca = mantis->mantis_ca;
stat = mmread(MANTIS_INT_STAT); stat = mmread(MANTIS_INT_STAT);
......
...@@ -69,10 +69,8 @@ static irqreturn_t mantis_irq_handler(int irq, void *dev_id) ...@@ -69,10 +69,8 @@ static irqreturn_t mantis_irq_handler(int irq, void *dev_id)
struct mantis_ca *ca; struct mantis_ca *ca;
mantis = (struct mantis_pci *) dev_id; mantis = (struct mantis_pci *) dev_id;
if (unlikely(mantis == NULL)) { if (unlikely(!mantis))
dprintk(MANTIS_ERROR, 1, "Mantis == NULL");
return IRQ_NONE; return IRQ_NONE;
}
ca = mantis->mantis_ca; ca = mantis->mantis_ca;
stat = mmread(MANTIS_INT_STAT); stat = mmread(MANTIS_INT_STAT);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment