Commit 632b89e8 authored by Dave Chinner's avatar Dave Chinner Committed by Ben Myers

xfs: fix static and extern sparse warnings

The kbuild test robot indicated that there were some new sparse
warnings in fs/xfs/xfs_dquot_buf.c. Actually, there were a lot more
that is wasn't warning about, so fix them all up.

Reported-by: kbuild test robot
Signed-off-by: default avatarDave Chinner <dchinner@redhat.com>
Reviewed-by: default avatarBen Myers <bpm@sgi.com>
Signed-off-by: default avatarBen Myers <bpm@sgi.com>
parent a6293621
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_bit.h"
/* /*
* XFS bit manipulation routines, used in non-realtime code. * XFS bit manipulation routines, used in non-realtime code.
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
......
...@@ -809,7 +809,7 @@ xfs_buf_item_init( ...@@ -809,7 +809,7 @@ xfs_buf_item_init(
* Mark bytes first through last inclusive as dirty in the buf * Mark bytes first through last inclusive as dirty in the buf
* item's bitmap. * item's bitmap.
*/ */
void static void
xfs_buf_item_log_segment( xfs_buf_item_log_segment(
struct xfs_buf_log_item *bip, struct xfs_buf_log_item *bip,
uint first, uint first,
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
...@@ -706,7 +707,7 @@ xfs_dir3_free_hdr_to_disk( ...@@ -706,7 +707,7 @@ xfs_dir3_free_hdr_to_disk(
hdr3->nused = cpu_to_be32(from->nused); hdr3->nused = cpu_to_be32(from->nused);
} }
const struct xfs_dir_ops xfs_dir2_ops = { static const struct xfs_dir_ops xfs_dir2_ops = {
.sf_entsize = xfs_dir2_sf_entsize, .sf_entsize = xfs_dir2_sf_entsize,
.sf_nextentry = xfs_dir2_sf_nextentry, .sf_nextentry = xfs_dir2_sf_nextentry,
.sf_get_ftype = xfs_dir2_sfe_get_ftype, .sf_get_ftype = xfs_dir2_sfe_get_ftype,
...@@ -756,7 +757,7 @@ const struct xfs_dir_ops xfs_dir2_ops = { ...@@ -756,7 +757,7 @@ const struct xfs_dir_ops xfs_dir2_ops = {
.db_to_fdindex = xfs_dir2_db_to_fdindex, .db_to_fdindex = xfs_dir2_db_to_fdindex,
}; };
const struct xfs_dir_ops xfs_dir2_ftype_ops = { static const struct xfs_dir_ops xfs_dir2_ftype_ops = {
.sf_entsize = xfs_dir3_sf_entsize, .sf_entsize = xfs_dir3_sf_entsize,
.sf_nextentry = xfs_dir3_sf_nextentry, .sf_nextentry = xfs_dir3_sf_nextentry,
.sf_get_ftype = xfs_dir3_sfe_get_ftype, .sf_get_ftype = xfs_dir3_sfe_get_ftype,
...@@ -806,7 +807,7 @@ const struct xfs_dir_ops xfs_dir2_ftype_ops = { ...@@ -806,7 +807,7 @@ const struct xfs_dir_ops xfs_dir2_ftype_ops = {
.db_to_fdindex = xfs_dir2_db_to_fdindex, .db_to_fdindex = xfs_dir2_db_to_fdindex,
}; };
const struct xfs_dir_ops xfs_dir3_ops = { static const struct xfs_dir_ops xfs_dir3_ops = {
.sf_entsize = xfs_dir3_sf_entsize, .sf_entsize = xfs_dir3_sf_entsize,
.sf_nextentry = xfs_dir3_sf_nextentry, .sf_nextentry = xfs_dir3_sf_nextentry,
.sf_get_ftype = xfs_dir3_sfe_get_ftype, .sf_get_ftype = xfs_dir3_sfe_get_ftype,
...@@ -856,14 +857,14 @@ const struct xfs_dir_ops xfs_dir3_ops = { ...@@ -856,14 +857,14 @@ const struct xfs_dir_ops xfs_dir3_ops = {
.db_to_fdindex = xfs_dir3_db_to_fdindex, .db_to_fdindex = xfs_dir3_db_to_fdindex,
}; };
const struct xfs_dir_ops xfs_dir2_nondir_ops = { static const struct xfs_dir_ops xfs_dir2_nondir_ops = {
.node_hdr_size = sizeof(struct xfs_da_node_hdr), .node_hdr_size = sizeof(struct xfs_da_node_hdr),
.node_hdr_to_disk = xfs_da2_node_hdr_to_disk, .node_hdr_to_disk = xfs_da2_node_hdr_to_disk,
.node_hdr_from_disk = xfs_da2_node_hdr_from_disk, .node_hdr_from_disk = xfs_da2_node_hdr_from_disk,
.node_tree_p = xfs_da2_node_tree_p, .node_tree_p = xfs_da2_node_tree_p,
}; };
const struct xfs_dir_ops xfs_dir3_nondir_ops = { static const struct xfs_dir_ops xfs_dir3_nondir_ops = {
.node_hdr_size = sizeof(struct xfs_da3_node_hdr), .node_hdr_size = sizeof(struct xfs_da3_node_hdr),
.node_hdr_to_disk = xfs_da3_node_hdr_to_disk, .node_hdr_to_disk = xfs_da3_node_hdr_to_disk,
.node_hdr_from_disk = xfs_da3_node_hdr_from_disk, .node_hdr_from_disk = xfs_da3_node_hdr_from_disk,
......
...@@ -18,6 +18,7 @@ ...@@ -18,6 +18,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
...@@ -267,7 +268,7 @@ xfs_dquot_buf_read_verify( ...@@ -267,7 +268,7 @@ xfs_dquot_buf_read_verify(
* the buffer after the update is done. This ensures that the dquot in the * the buffer after the update is done. This ensures that the dquot in the
* buffer always has an up-to-date CRC value. * buffer always has an up-to-date CRC value.
*/ */
void static void
xfs_dquot_buf_write_verify( xfs_dquot_buf_write_verify(
struct xfs_buf *bp) struct xfs_buf *bp)
{ {
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
......
...@@ -37,6 +37,7 @@ ...@@ -37,6 +37,7 @@
#include "xfs_buf.h" #include "xfs_buf.h"
#include "xfs_icache.h" #include "xfs_icache.h"
#include "xfs_dinode.h" #include "xfs_dinode.h"
#include "xfs_rtalloc.h"
/* /*
......
...@@ -17,6 +17,7 @@ ...@@ -17,6 +17,7 @@
*/ */
#include "xfs.h" #include "xfs.h"
#include "xfs_fs.h" #include "xfs_fs.h"
#include "xfs_shared.h"
#include "xfs_format.h" #include "xfs_format.h"
#include "xfs_log_format.h" #include "xfs_log_format.h"
#include "xfs_trans_resv.h" #include "xfs_trans_resv.h"
......
...@@ -1155,7 +1155,7 @@ xfs_restore_resvblks(struct xfs_mount *mp) ...@@ -1155,7 +1155,7 @@ xfs_restore_resvblks(struct xfs_mount *mp)
* Note: xfs_log_quiesce() stops background log work - the callers must ensure * Note: xfs_log_quiesce() stops background log work - the callers must ensure
* it is started again when appropriate. * it is started again when appropriate.
*/ */
void static void
xfs_quiesce_attr( xfs_quiesce_attr(
struct xfs_mount *mp) struct xfs_mount *mp)
{ {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment