Commit 660fe0d6 authored by Filipe Manana's avatar Filipe Manana Committed by Luis Henriques

Btrfs: use kmem_cache_free when freeing entry in inode cache

commit c3f4a168 upstream.

The free space entries are allocated using kmem_cache_zalloc(),
through __btrfs_add_free_space(), therefore we should use
kmem_cache_free() and not kfree() to avoid any confusion and
any potential problem. Looking at the kfree() definition at
mm/slab.c it has the following comment:

  /*
   * (...)
   *
   * Don't free memory not originally allocated by kmalloc()
   * or you will run into trouble.
   */

So better be safe and use kmem_cache_free().
Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.cz>
Signed-off-by: default avatarChris Mason <clm@fb.com>
Signed-off-by: default avatarLuis Henriques <luis.henriques@canonical.com>
parent 08e5cda9
...@@ -271,7 +271,7 @@ void btrfs_unpin_free_ino(struct btrfs_root *root) ...@@ -271,7 +271,7 @@ void btrfs_unpin_free_ino(struct btrfs_root *root)
__btrfs_add_free_space(ctl, info->offset, count); __btrfs_add_free_space(ctl, info->offset, count);
free: free:
rb_erase(&info->offset_index, rbroot); rb_erase(&info->offset_index, rbroot);
kfree(info); kmem_cache_free(btrfs_free_space_cachep, info);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment