Commit 6a3e6aa1 authored by Julia Lawall's avatar Julia Lawall Committed by David S. Miller

ll_temac: delete unneeded test before of_node_put

Of_node_put supports NULL as its argument, so the initial test is not
necessary.

Suggested by Uwe Kleine-König.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
@@

-if (e)
   of_node_put(e);
// </smpl>
Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: default avatarMichal Simek <michal.simek@xilinx.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f3a59ac
...@@ -1148,8 +1148,7 @@ static int temac_of_remove(struct platform_device *op) ...@@ -1148,8 +1148,7 @@ static int temac_of_remove(struct platform_device *op)
temac_mdio_teardown(lp); temac_mdio_teardown(lp);
unregister_netdev(ndev); unregister_netdev(ndev);
sysfs_remove_group(&lp->dev->kobj, &temac_attr_group); sysfs_remove_group(&lp->dev->kobj, &temac_attr_group);
if (lp->phy_node) of_node_put(lp->phy_node);
of_node_put(lp->phy_node);
lp->phy_node = NULL; lp->phy_node = NULL;
iounmap(lp->regs); iounmap(lp->regs);
if (lp->sdma_regs) if (lp->sdma_regs)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment