Commit 6c486979 authored by Leon Romanovsky's avatar Leon Romanovsky Committed by Jakub Kicinski

netdevsim: Fill IPsec state validation failure reason

Rely on extack to return failure reason.
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 902812b8
...@@ -140,25 +140,24 @@ static int nsim_ipsec_add_sa(struct xfrm_state *xs, ...@@ -140,25 +140,24 @@ static int nsim_ipsec_add_sa(struct xfrm_state *xs,
ipsec = &ns->ipsec; ipsec = &ns->ipsec;
if (xs->id.proto != IPPROTO_ESP && xs->id.proto != IPPROTO_AH) { if (xs->id.proto != IPPROTO_ESP && xs->id.proto != IPPROTO_AH) {
netdev_err(dev, "Unsupported protocol 0x%04x for ipsec offload\n", NL_SET_ERR_MSG_MOD(extack, "Unsupported protocol for ipsec offload");
xs->id.proto);
return -EINVAL; return -EINVAL;
} }
if (xs->calg) { if (xs->calg) {
netdev_err(dev, "Compression offload not supported\n"); NL_SET_ERR_MSG_MOD(extack, "Compression offload not supported");
return -EINVAL; return -EINVAL;
} }
if (xs->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) { if (xs->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) {
netdev_err(dev, "Unsupported ipsec offload type\n"); NL_SET_ERR_MSG_MOD(extack, "Unsupported ipsec offload type");
return -EINVAL; return -EINVAL;
} }
/* find the first unused index */ /* find the first unused index */
ret = nsim_ipsec_find_empty_idx(ipsec); ret = nsim_ipsec_find_empty_idx(ipsec);
if (ret < 0) { if (ret < 0) {
netdev_err(dev, "No space for SA in Rx table!\n"); NL_SET_ERR_MSG_MOD(extack, "No space for SA in Rx table!");
return ret; return ret;
} }
sa_idx = (u16)ret; sa_idx = (u16)ret;
...@@ -173,7 +172,7 @@ static int nsim_ipsec_add_sa(struct xfrm_state *xs, ...@@ -173,7 +172,7 @@ static int nsim_ipsec_add_sa(struct xfrm_state *xs,
/* get the key and salt */ /* get the key and salt */
ret = nsim_ipsec_parse_proto_keys(xs, sa.key, &sa.salt); ret = nsim_ipsec_parse_proto_keys(xs, sa.key, &sa.salt);
if (ret) { if (ret) {
netdev_err(dev, "Failed to get key data for SA table\n"); NL_SET_ERR_MSG_MOD(extack, "Failed to get key data for SA table");
return ret; return ret;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment