Commit 6f5a55f1 authored by Linus Torvalds's avatar Linus Torvalds

Fix potential crash with sys_move_pages

We incorrectly depended on the 'node_state/node_isset()' functions
testing the node range, rather than checking it explicitly.  That's not
reliable, even if it might often happen to work.  So do the proper
explicit test.
Reported-by: default avatarMarcus Meissner <meissner@suse.de>
Acked-and-tested-by: default avatarBrice Goglin <Brice.Goglin@inria.fr>
Acked-by: default avatarHugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: stable@kernel.org
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 9d9c3a51
...@@ -912,6 +912,9 @@ static int do_pages_move(struct mm_struct *mm, struct task_struct *task, ...@@ -912,6 +912,9 @@ static int do_pages_move(struct mm_struct *mm, struct task_struct *task,
goto out_pm; goto out_pm;
err = -ENODEV; err = -ENODEV;
if (node < 0 || node >= MAX_NUMNODES)
goto out_pm;
if (!node_state(node, N_HIGH_MEMORY)) if (!node_state(node, N_HIGH_MEMORY))
goto out_pm; goto out_pm;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment